Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timestamps with ms #75

Merged
merged 24 commits into from
Feb 4, 2025
Merged

Timestamps with ms #75

merged 24 commits into from
Feb 4, 2025

Conversation

afonsoCarreira1
Copy link
Contributor

No description provided.

adelnoureddine and others added 20 commits February 21, 2023 18:11
@adelnoureddine
Add Citation file
acc85df
@adelnoureddine
Add paper citation
ec074f9
@adelnoureddine
Merge pull request joular#18 from joular/develop
c596c30 
Develop
@adelnoureddine
Merge pull request joular#19 from joular/develop
03a1c7f 
Update README.md
@adelnoureddine
Merge pull request joular#20 from joular/develop
701e6d9 
Update README.md
@adelnoureddine
Update README.md
bbc6b9c
@adelnoureddine
Merge pull request joular#22 from joular/develop
18acfa6 
Fix issue joular#21 with Monitored_Time value not updated
@adelnoureddine
Merge pull request joular#28 from joular/develop
e2b8a8e 
Preparing version 0.6.2 with AMD EPYC
@adelnoureddine
Merge pull request joular#35 from joular/develop
92d4a0e 
Version 0.7.0
@adelnoureddine
Merge pull request joular#40 from joular/develop
7b30c9e 
0.7.1
@adelnoureddine
Merge pull request joular#44 from joular/develop
509d181 
Version 0.7.2
@adelnoureddine
Merge pull request joular#48 from joular/develop
2308f2e 
0.7.3
@adelnoureddine
Merge pull request joular#49 from joular/develop
46db963 
remove rpm code
@adelnoureddine
Merge pull request joular#55 from joular/develop
634c5cf 
Version 1.0.0
@adelnoureddine
Merge pull request joular#57 from joular/develop
579fe89 
Version 1.0.1
@adelnoureddine
Merge pull request joular#59 from joular/develop
1cb2359 
1.0.2
@adelnoureddine
Merge pull request joular#60 from joular/develop
9a5a006 
Hotfix for handling exceptions for command line arguments
@adelnoureddine
Merge pull request joular#62 from joular/develop
4a791cd 
1.0.4
@adelnoureddine
Merge pull request joular#70 from joular/develop
cbd80a9 
1.0.5
@afonsoCarreira1
added timestamps with ms to the output csv
b6ed98f
@adelnoureddine adelnoureddine self-assigned this Dec 15, 2024
@adelnoureddine
Copy link
Member

adelnoureddine commented Jan 16, 2025 •
edited
Loading

Thanks @afonsoCarreira1.
I think having data in seconds by default and writing them in milliseconds through a flag is a better option.

So, I recommend:

  • Add a flag to activate milliseconds display. For instance a flag -c
  • Have a variable for millisecond flag, default to False
  • Check it in CSV_Power module, and call Get_Timestamp if True, otherwise kee the previous Put line.

@afonsoCarreira1
Copy link
Contributor Author

I completed all the steps, hope everything is fine.

@adelnoureddine
Copy link
Member

Thanks @afonsoCarreira1. I did some styling changes and updated README. I'll merge this PR.

@adelnoureddine adelnoureddine added this to the 1.1 milestone Feb 4, 2025
@adelnoureddine adelnoureddine merged commit e5bdb24 into joular:develop Feb 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adelnoureddine adelnoureddine adelnoureddine approved these changes

Assignees

@adelnoureddine adelnoureddine

Labels
None yet
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@afonsoCarreira1 @adelnoureddine