Try to improve Reflex command queue lookups #184
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us avoid having to
QueryInterface
on every call toNvAPI_D3D12_SetAsyncFrameMarker
. The consequence of doing it like this is that now there might be multiple entries inm_lowLatencyDeviceMap
pointing to the sameID3DLowLatencyDevice
so in order to still correctly have a single frame ID generator perID3DLowLatencyDevice
, their map is now keyed on low latency devices which we have to retrieve on every call anyway.We could further reduce the lookups if we either returned intermediate
ID3DLowLatencyDevice
fromSupportsLowLatency
and then acted on it in the following call or if we just got rid of explicitSupportsLowLatency
and had methods likeSetFrameMarker
returned more detailed error codes (or justNvAPI_Status
directly). But that's an idea for another day.