Add initial nvofapi tests #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jp7677
force-pushed
the
nvofapi-resourcefactory
branch
6 times, most recently
from
8741522 to
60a57d2
Compare
jp7677
force-pushed
the
nvofapi-resourcefactory
branch
3 times, most recently
from
a343dc7 to
4323e7c
Compare
Saancreed
reviewed
Jan 30, 2025
jp7677
force-pushed
the
nvofapi-resourcefactory
branch
2 times, most recently
from
90eff35 to
c613a2b
Compare
Saancreed
reviewed
Jan 31, 2025
jp7677
force-pushed
the
nvofapi-resourcefactory
branch
from
c613a2b to
872dd78
Compare
Saancreed
approved these changes
Feb 1, 2025
Yes, that would be nice. Thanks! |
Also split current ResourceFactory into ResourceFactory and NvapiResourceFactory to keep Shared free from dxgi. lfx and nvml.
Technically this changes the behavior from loading the corresponding Vulkan library into just retrieving a handle of already-loaded one. Probably doesn't matter though, it shouldn't be possible to create ID3D12Device from vkd3d-proton without having winevulkan loaded.
Move mocks and resource factory related files to separate folder.
jp7677
force-pushed
the
nvofapi-resourcefactory
branch
from
872dd78 to
c8c60a4
Compare
|
It does appear to be working, both D3D12 and Vulkan flavors (the latter in Portal RTX), although the version is reported strangely, even after
But yeah, working fine. |
This was referenced Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just the very basics and and some preparations. Not yet tested.