♻️ Render author image with picture partial #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for hugo-congo ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
remove superfluous warning
remove superfluous log element
|
Any questions or concerns here? |
|
Yes, definitely a good direction to go with this one. I just haven't had time to review it. I'm trying to get my head around why the width and height being the same are causing issues. |
jpanther
changed the title
|
Finally had a chance to review this and it looks good to me. I'll merge it in now. Thanks for your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in lieu of #687 This uses the picture partial image rendering path to generate the author content.
Screens included to show SVG working.
An interesting behavior manifests if the width and height classes are the same in
layouts/partials/author.html:(screens included to illustrate the problem)
What seems to be the "best" way forward is to specify w explicity, and set H to
auto