feat: support strict models by handling MissingAttributeException
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update ensures compatibility with Laravel's `Model::shouldBeStrict()` feature.
For example, the following code may throw a `MissingAttributeException` if any defined attribute event attributes are not fetched:
```php
Order::query()->pluck('status', 'id');
```
To address this, each `getAttribute()` call is now wrapped in a try-catch block, preventing exceptions and maintaining functionality in strict mode.
|
Hi @jpkleemans, I hope you’re doing well! Just a kind reminder to take a look at this when you have a moment. The changes address compatibility issues with Filament PHP in strict mode due to the pluck operations. Please let me know if there’s anything I can do to help with the review process. Thanks so much for your time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update ensures compatibility with Laravel's
Model::shouldBeStrict()feature.For example, the following code may throw a
MissingAttributeExceptionif any defined attribute event attributes are not fetched:To address this, each
getAttribute()call is now wrapped in a try-catch block, preventing exceptions and maintaining functionality in strict mode.