Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid long-lived reference to DOM Element within lambda closure #291

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

barspi
Copy link
Contributor

@barspi barspi commented Nov 20, 2023

A reference to the Element (therefore, to the whole DOM tree) was held by the long-lived and lazily-evaluated lambda closure.

This fix is more a "matter of principles", since the whole persist DOM is still being held by the QBean itself during its lifetime. But it's a saner pattern not to hold on to unneeded references for too long.

@ar ar merged commit 3e8ebd7 into jpos:master Nov 20, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants