Avoid long-lived reference to DOM Element within lambda closure #291
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A reference to the
Element
(therefore, to the whole DOM tree) was held by the long-lived and lazily-evaluated lambda closure.This fix is more a "matter of principles", since the whole
persist
DOM is still being held by theQBean
itself during its lifetime. But it's a saner pattern not to hold on to unneeded references for too long.