ISOServer/ChannelAdaptor default to Platform Threads.

During 'jinstress' test we found that for persistent connections, the ChannelAdaptor and ISOServer performs better using platform threads. There are situations, such as a massive number of low-traffic POS devices that could be better served using VirtualThreads, so there's still the ability to set 'virtual-threads' to 'true' in the components' configuration.
jpos · Jan 2, 2025 · 53b10f2 · 53b10f2
1 parent 0da87e6
commit 53b10f2
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/jpos/src/main/java/org/jpos/iso/ISOServer.java b/jpos/src/main/java/org/jpos/iso/ISOServer.java
@@ -44,6 +44,7 @@
 import org.jpos.jfr.ChannelEvent;
 import org.jpos.log.AuditLogEvent;
 import org.jpos.log.evt.*;
+import org.jpos.q2.QFactory;
 import org.jpos.util.*;
 
 /**
@@ -117,7 +118,6 @@ public ISOServer(int port, ServerChannel clientSide, int maxSessions) {
         channels = Collections.synchronizedMap(new HashMap<>());
         serverListeners = Collections.synchronizedList(new ArrayList<>());
 
-        executor = Executors.newVirtualThreadPerTaskExecutor();
         if (maxSessions > 0)
             permitsCount = maxSessions;
         permits = new Semaphore(permitsCount);
@@ -143,6 +143,7 @@ public void setConfiguration (Configuration cfg) throws ConfigurationException {
         if (socketFactory != this && socketFactory instanceof Configurable) {
             ((Configurable)socketFactory).setConfiguration (cfg);
         }
+        executor = QFactory.executorService(cfg.getBoolean("virtual-threads", false));
     }
 
     // Helper method to setConfiguration. Handles "allow" and "deny" params

diff --git a/jpos/src/main/java/org/jpos/q2/iso/ChannelAdaptor.java b/jpos/src/main/java/org/jpos/q2/iso/ChannelAdaptor.java
@@ -85,7 +85,7 @@ public ChannelAdaptor () {
     public void initService() throws ConfigurationException {
         initSpaceAndQueues();
         NameRegistrar.register (getName(), this);
-        executor = Executors.newVirtualThreadPerTaskExecutor();
+        executor = QFactory.executorService(cfg.getBoolean("virtual-threads", false));
     }
     public void startService () {
         try {

diff --git a/jpos/src/main/java/org/jpos/transaction/TransactionManager.java b/jpos/src/main/java/org/jpos/transaction/TransactionManager.java
@@ -133,11 +133,7 @@ public void initService () throws ConfigurationException {
         groups = new HashMap<>();
         initParticipants (getPersist());
         initStatusListeners (getPersist());
-        executor = Executors.newThreadPerTaskExecutor(
-          Thread.ofVirtual()
-          .inheritInheritableThreadLocals(false)
-          .name(getName())
-          .factory());
+        executor = QFactory.executorService(cfg.getBoolean("virtual-threads", true));
 
         if (!filtersAdded.getAndSet(true)) {
             getServer().getMeterRegistry().config().meterFilter(new MeterFilter() {
@@ -239,8 +235,8 @@ public void run () {
                     });
                 }
                 else {
-                    ISOUtil.sleep(100L);
                     iisp.push(queue, context);  // push it back
+                    ISOUtil.sleep(100L);
                 }
             }
         }