-
-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Japanese translations and implement I18N support #1920
base: develop
Are you sure you want to change the base?
Conversation
- Add Japanese translations for documentation - Implement I18N framework - Update mkdocs.yml for multi-language support This commit significantly enhances the project's internationalization.
Hi, @yostos! Wow! This seems like it must have been a lot of work, so thank you! A few notes:
Does that make sense? And please let us know if you need help with any of these things. |
|
||
```sh | ||
┎──────────────────────────────────────────────────────────────────────╮2020-06-28 18:22 | ||
┃ これは最初のサンプルエントリーです ╘═══════════════╕ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For whatever reason, each of these three example output displays appears to be about 5 characters short of the visual "box" alignment. (The Japanese does have fewer characters than the English, but that doesn't seem to account for the difference.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Translation review. I reviewed the docs/ja
folder and did spot checks throughout a few files, with the PR and original code view side by side:
- contributing.md
- formats.md
- installation.md
- overview.md
- tips-and-tricks.mf
- usage.md
FWIW, the translation looks solid and natural to me.
Notes and caveats
- My Japanese is fluent, but I'm not particularly familiar with any semantic conventions that might apply to technical documentation.
- That said, the translation does a good job of maintaining the casual but clear tone of the English.
- I left one comment where the visual formatting of a box style was misaligned, but I didn't otherwise notice any oddities with code formatting or over-translation (such as code text being translated where it shouldn't be).
This pull request adds Japanese translations for the documentation and implements I18N support for the project.
Intended changes:
Motivation:
To make the project more accessible to Japanese-speaking users and to establish a framework for easy addition of other languages in the future.
There are no directly related issues, but this change aligns with the project's goal of international accessibility.
Example of changes:
Checklist
for the same issue.