Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: 1.0.1 #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Release: 1.0.1 #58

wants to merge 1 commit into from

Conversation

UlisesGascon
Copy link
Member

@UlisesGascon UlisesGascon commented Oct 29, 2024

Plan to release it on Nov 06

What's included in the HISTORY.md

  • Updated engines field to Node@18 or higher
  • Remove dependency safe-buffer

What's Changed

New Contributors

Full Changelog: v1.0.0...master

@UlisesGascon
Copy link
Member Author

Current plan is to release it today.

@Phillip9587
Copy link
Contributor

Hey @UlisesGascon , please consider adding #56 to the release. The commit removing the safe-buffer package is based on the assumption that only node versions v18 and newer are supported.

Signed-off-by: Ulises Gascon <[email protected]>
@UlisesGascon
Copy link
Member Author

UlisesGascon commented Nov 6, 2024

Added! thanks for the ping @Phillip9587 👍

@wesleytodd
Copy link
Member

This should technically be a major. But, because it is our states support policy that engines should have been 18 on 1.0.0 release, I am willing to bend as long as we make this a minor (not patch like it is now).

@Phillip9587
Copy link
Contributor

Hey @UlisesGascon, Just wanted to kindly check if there’s an ETA for when this release might go out? Looking forward to it!

@UlisesGascon
Copy link
Member Author

Probably Jan'25 🎄

@Phillip9587
Copy link
Contributor

Hey @UlisesGascon, just wanted to check in on the status of this release. This is the last of Express's direct dependencies that uses the safe-buffer package. I'm looking forward to removing it from our dependency tree :-)

@wesleytodd
Copy link
Member

I will be assembling a list of releases we need to do next week. If @UlisesGascon doesn't time before then I can take this on. I will be doing two passes to make sure we release all the pending things for express first, then update them and release in express.

@wesleytodd
Copy link
Member

There are two PRs we could land before we push this:

#55
#54

Neither required, just wanted to call them out.

Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I'm not sure if the engine update will be in a patch or minor, but I'm sure it won't be in a patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants