Skip to content

Commit

Permalink
fix urlencoded compressibility
Browse files Browse the repository at this point in the history
  • Loading branch information
@jonathanong
jonathanong committed Oct 20, 2014
1 parent 7ed1758 commit 20925f7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/compressible.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@
"application/x-tar": {
"compressible": true
},
"application/x-www-form-urlencode": {
"application/x-www-form-urlencoded": {
"compressible": false
},
"application/x-xpinstall": {
Expand Down

7 comments on commit 20925f7

@jonathanong
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait. why is this false? shouldn't it be true?

@dougwilson
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like it was false from where ever this came from. it certainly could be true, since it's just text. @Fishrock123 may have some reasoning, though

@Fishrock123
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember there was a thing or two that were strictly accepted in plain text. This may have been one of those, unless you guys know otherwise. (I don't have the time to look into it right now.)

@Fishrock123
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea why there wouldn't be a note on it then, though. I'd say it would be compressible.

@dougwilson
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. let's just flip it to true

@dougwilson
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P.S. this change never got rebuilt, so 1.1.1 didn't actually do anything, since it wasn't updated in the database file.

@jonathanong
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

damnit

Please sign in to comment.