Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ADOPTERS.md #533

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Update ADOPTERS.md #533

merged 3 commits into from
Jan 3, 2024

Conversation

jbfaden
Copy link
Contributor

@jbfaden jbfaden commented Nov 16, 2023

GitHub Issue: # / NA

Summary:

Do you think resolving this issue might require an Architectural Decision Record (ADR)? (significant or noteworthy)

Yes/No
[JUSTIFICATION]

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for adding the HAPI Server specification use case to the Adopters List! We love standards! And thanks for bringing use cases interesting for researchers and scientist!

Everything looks good to me. I just left a comment to check with you what is the document describing better your use case, so people looking for something similar can understand better your approach.

ADOPTERS.md Outdated
| [Manfred](https://www.getmanfred.com/) | [David Bonilla](https://www.linkedin.com/in/dbonillaf/) | [The MAC is a standard open source format created by Manfred to define and share CVs](https://github.com/getmanfred/mac) |
| [HAPI Server](https://hapi-server.org/) | [Jeremy Faden](https://cottagesystems.com/) | [Server responses can be verified against a schema, accelerating development of correct servers](https://github.com/hapi-server/data-specification-schema) |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for adding the HAPI Server specification use case to the Adopters List!

I am wondering if it may be more descriptive of your case if we use this repo instead: https://github.com/hapi-server/verifier-nodejs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that shows the schema use embedded within a code. The schemas can be used in JSON editors as well. Either link is fine.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @jbfaden! Huge thanks for supporting the Adopters program!

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for addressing all the changes. This PR is ready to merge.

ADOPTERS.md Outdated
| [Manfred](https://www.getmanfred.com/) | [David Bonilla](https://www.linkedin.com/in/dbonillaf/) | [The MAC is a standard open source format created by Manfred to define and share CVs](https://github.com/getmanfred/mac) |
| [HAPI Server](https://hapi-server.org/) | [Jeremy Faden](https://cottagesystems.com/) | [Server responses can be verified against a schema, accelerating development of correct servers](https://github.com/hapi-server/data-specification-schema) |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| [HAPI Server](https://hapi-server.org/) | [Jeremy Faden](https://cottagesystems.com/) | [Server responses can be verified against a schema, accelerating development of correct servers](https://github.com/hapi-server/data-specification-schema) |
| [HAPI Specification](https://hapi-server.org/) | [Jeremy Faden](https://cottagesystems.com/) | [HAPI Server responses can be verified against a schema, accelerating development of correct servers](https://github.com/hapi-server/data-specification-schema) |

Last comment before merging: Is it ok if we use HAPI Specification instead of HAPI Server?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure that's fine.

@benjagm
Copy link
Collaborator

benjagm commented Jan 2, 2024

Thanks for addressing all the changes @jbfaden and our apologies for making the review process too long.

Is it ok if we merge and promote HAPI as Adopter?

Huge thanks for promoting the usage of JSON Schema!

@benjagm benjagm merged commit e3e5af6 into json-schema-org:main Jan 3, 2024
1 check passed
@benjagm
Copy link
Collaborator

benjagm commented Jan 3, 2024

We just promoted HAPI-Server as Adopter in Social media. Huge thanks @jbfaden for supporting us by adding HAPI.

The social posts:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants