Implement unix time and rfc3339 parsing #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleg Zaytsev <[email protected]>
Signed-off-by: Oleg Zaytsev <[email protected]>
colega
commented
Oct 31, 2023
Comment on lines
+182
to
+184
| date + time + { | ||
| toUnixTimestamp():: $.toUnixTimestamp(self.year, self.month, self.day, self.hour, self.minute, self.second), | ||
| }, |
There was a problem hiding this comment.
This isn't the most functional approach, but it's easy to use. I'm happy to listen for your suggestions.
colega
commented
Oct 31, 2023
Comment on lines
+161
to
+173
| // Sub-second precision isn't implemented yet, warn the user about that instead of returning wrong results. | ||
| assert !stringContains(input, '.') : 'the provided RFC3339 input "%s" has a dot, most likely representing a sub-second precision, but this function does not support that' % input; | ||
|
|
||
| // We don't support timezones, so string should end with 'Z' or 'z'. | ||
| assert std.endsWith(input, 'Z') || std.endsWith(input, 'z') : 'the provided RFC3339 "%s" should end with "Z" or "z". This implementation does not currently support timezones' % input; | ||
|
|
||
| // RFC3339 can separate date and time using 'T', 't' or ' '. | ||
| // Find out which one it is and use it. | ||
| local sep = | ||
| if stringContains(input, 'T') then 'T' | ||
| else if stringContains(input, 't') then 't' | ||
| else if stringContains(input, ' ') then ' ' | ||
| else error 'the provided RFC3339 input "%s" should contain either a "T", or a "t" or space " " as a separator for date and time parts' % input; |
There was a problem hiding this comment.
@Duologic as you asked in grafana/jsonnet-libs#1095, I added support for lowercase t/z and also for space separator.
colega
commented
Oct 31, 2023
Comment on lines
+105
to
+112
| // isNumeric checks that the input is a non-empty string containing only digit characters. | ||
| local isNumeric(input) = | ||
| assert std.type(input) == 'string' : 'isNumeric() only operates on string inputs, got %s' % std.type(input); | ||
| std.foldl( | ||
| function(acc, char) acc && std.codepoint('0') <= std.codepoint(char) && std.codepoint(char) <= std.codepoint('9'), | ||
| std.stringChars(input), | ||
| std.length(input) > 0, | ||
| ), |
There was a problem hiding this comment.
@jdbaldry I borrowed the implementation from your comment here :)
colega
commented
Oct 31, 2023
Comment on lines
+89
to
+103
| '#toUnixTimestamp': d.fn( | ||
| ||| | ||
| `toUnixTimestamp` calculates the unix timestamp of a given date. | ||
| |||, | ||
| [ | ||
| d.arg('year', d.T.number), | ||
| d.arg('month', d.T.number), | ||
| d.arg('day', d.T.number), | ||
| d.arg('hour', d.T.number), | ||
| d.arg('minute', d.T.number), | ||
| d.arg('second', d.T.number), | ||
| ], | ||
| ), | ||
| toUnixTimestamp(year, month, day, hour, minute, second):: | ||
| sumYearsSeconds(year) + sumMonthsSeconds(year, month) + sumDaysSeconds(day) + hour * 3600 + minute * 60 + second, |
There was a problem hiding this comment.
This was already in github.com/grafana/jsonnet-libs/date, now I'm bringing here as it's useful once we've parsed the RFC3339.
Signed-off-by: Oleg Zaytsev <[email protected]>
malcolmholmes
approved these changes
Nov 2, 2023
| ``` | ||
|
|
||
| `parseRFC3339` parses an RFC3339-formatted date & time string into an object containing the 'year', 'month', 'day', 'hour', 'minute' and 'second fields. |
There was a problem hiding this comment.
Would be useful to have an example of an RFC3339 date/time for those of us that know the format but not the RFC number.
There was a problem hiding this comment.
Sure, followed up in #24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements
timefunctionstoUnixTimestampthat calculates a unix timestamp of a date/time, andparseRFC3339that does some limited parsing of RFC3339 timestamps.