add isStringNumeric to library #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mauro Stettler <[email protected]>
Signed-off-by: Mauro Stettler <[email protected]>
Signed-off-by: Mauro Stettler <[email protected]>
replay
changed the title
Duologic
reviewed
Feb 22, 2024
Co-authored-by: Jeroen Op 't Eynde <[email protected]>
Duologic
approved these changes
Feb 22, 2024
Duologic
reviewed
Feb 22, 2024
Co-authored-by: Jeroen Op 't Eynde <[email protected]>
|
ping @Duologic , do you think we can merge this? |
Duologic
approved these changes
Mar 1, 2024
|
@Duologic sorry to ping again, but I can't merge this myself :) It says:
|
|
No worries, I approved while on my phone, couldn't fix the failing test there. Just fixed it, merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
helper function to check whether all characters in a string are numeric