fix: --npm flag not being respected (#52)

jsr-io · Mar 8, 2024 · d4e5408 · d4e5408
1 parent ec0fdbc
commit d4e5408
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/src/bin.ts b/src/bin.ts
@@ -196,6 +196,8 @@ if (args.length === 0) {
       ? "yarn"
       : options.values.bun
       ? "bun"
+      : options.values.npm
+      ? "npm"
       : null;
 
     if (cmd === "i" || cmd === "install" || cmd === "add") {

diff --git a/test/commands.test.ts b/test/commands.test.ts
@@ -336,6 +336,25 @@ describe("install", () => {
       );
     });
 
+    it("overwrite detection with arg from npm_config_user_agent", async () => {
+      await withTempEnv(
+        ["i", "--npm", "@std/[email protected]"],
+        async (dir) => {
+          assert.ok(
+            await isFile(path.join(dir, "package-lock.json")),
+            "npm lockfile not created",
+          );
+        },
+        {
+          env: {
+            ...process.env,
+            npm_config_user_agent:
+              `pnpm/8.14.3 ${process.env.npm_config_user_agent}`,
+          },
+        },
+      );
+    });
+
     it("detect yarn from npm_config_user_agent", async () => {
       await withTempEnv(
         ["i", "@std/[email protected]"],