Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] prop-types: props missing in validation when using ComponentPropsWithRef from a namespace import #3870

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

corydeppen
Copy link

Fixes #3651.

Follows the pattern implemented in #3859 to prevent the "is missing in props validation" error when using destructured props with ComponentPropsWithRef.

Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.76%. Comparing base (5c816ed) to head (76a0e35).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3870      +/-   ##
==========================================
+ Coverage   94.34%   97.76%   +3.42%     
==========================================
  Files         133      136       +3     
  Lines        9966     9978      +12     
  Branches     3703     3703              
==========================================
+ Hits         9402     9755     +353     
+ Misses        564      223     -341     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: react/prop-types false positive when using React.ComponentProps
1 participant