CI: migrate upload artifact to v4 (#5570)

Co-authored-by: zhoucheng <[email protected]>
juicedata · Jan 24, 2025 · ef2717b · ef2717b
1 parent bf45087
commit ef2717b
Show file tree

Hide file tree

Showing 7 changed files with 59 additions and 38 deletions.
diff --git a/.github/workflows/command2.yml b/.github/workflows/command2.yml
@@ -93,23 +93,30 @@ jobs:
           fi
 
       - name: Download example database
-        uses: dawidd6/action-download-artifact@v6
+        timeout-minutes: 5
+        continue-on-error: true
+        uses: actions/download-artifact@v4
         with:
-          name: hypothesis-example-db
+          name: hypothesis-example-db-${{ matrix.meta }}
           path: .hypothesis/examples
-          if_no_artifact_found: warn
-          workflow_conclusion: completed
 
       - name: Run All
-        timeout-minutes: 70
+        continue-on-error: true
+        timeout-minutes: 60
         run: |
-          sudo -E LOG_LEVEL=WARNING META1=redis META2=${{matrix.meta}} timeout 3600 .github/scripts/command/random.sh test_run_all || code=$?; if [[ $code -eq 124 ]]; then echo test timeout with $code && exit 0; else echo failed with $code && exit $code; fi
+          sudo -E LOG_LEVEL=WARNING META1=redis META2=${{matrix.meta}} .github/scripts/command/random.sh test_run_all 2>&1 | tee fsrand.log
       
+      - name: Check fsrand.log
+        if: always()
+        run: |
+          grep "AssertionError" fsrand.log && exit 1 || true
+
       - name: Upload example database
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         if: always()
         with:
-          name: hypothesis-example-db
+          include-hidden-files: true
+          name: hypothesis-example-db-${{ matrix.meta }}
           path: .hypothesis/examples
 
       - name: Check client log

diff --git a/.github/workflows/fsrand.yml b/.github/workflows/fsrand.yml
@@ -15,7 +15,7 @@ on:
     - main
     - release**
     paths:
-    - '**/fsrand2.yml'
+    - '**/fsrand.yml'
     - '**/fs.py'
     - '**/fs_test.py'
     - '**/fs_acl_test.py'
@@ -29,7 +29,7 @@ on:
         required: false
         default: false
 jobs:
-  fsrand2:
+  fsrand:
     timeout-minutes: 60
     strategy:
       fail-fast: false
@@ -105,23 +105,30 @@ jobs:
           sudo -E python3 .github/scripts/hypo/fs_acl_test.py
 
       - name: Download example database
-        uses: dawidd6/action-download-artifact@v6
+        timeout-minutes: 5
+        continue-on-error: true
+        uses: actions/download-artifact@v4
         with:
-          name: hypothesis-example-db
+          name: hypothesis-example-db-${{ matrix.meta }}
           path: .hypothesis/examples
-          if_no_artifact_found: warn
-          workflow_conclusion: completed
 
       - name: Test
-        timeout-minutes: 125
+        continue-on-error: true
+        timeout-minutes: 120
         run: |
-          timeout 7200 sudo -E LOG_LEVEL=WARNING python3 .github/scripts/hypo/fs.py 2>&1 | tee fsrand.log || code=$?; if [[ $code -ne 124 && $code -ne 0 ]]; then echo test failed; exit $code; fi
+          sudo -E LOG_LEVEL=WARNING python3 .github/scripts/hypo/fs.py 2>&1 | tee fsrand.log
+      
+      - name: check fsrand.log
+        if: always()
+        run: | 
+          grep "AssertionError" fsrand.log && exit 1 || true
 
       - name: Upload example database
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         if: always()
         with:
-          name: hypothesis-example-db
+          include-hidden-files: true
+          name: hypothesis-example-db-${{ matrix.meta }}
           path: .hypothesis/examples
 
       - name: check fsrand.log
@@ -155,7 +162,7 @@ jobs:
 
   success-all-test:
     runs-on: ubuntu-latest
-    needs: [fsrand2]
+    needs: [fsrand]
     if: always()
     steps:
       - uses: technote-space/workflow-conclusion-action@v3

diff --git a/.github/workflows/gateway-random.yml b/.github/workflows/gateway-random.yml
@@ -81,30 +81,36 @@ jobs:
           fi
           sudo -E SUBDIR=$subdir .github/scripts/command/gateway-random.sh test_run_example
           
-        
       - name: Download example database
-        uses: dawidd6/action-download-artifact@v6
+        timeout-minutes: 5
+        continue-on-error: true
+        uses: actions/download-artifact@v4
         with:
-          name: hypothesis-example-db
+          name: hypothesis-example-db-${{ matrix.meta }}
           path: .hypothesis/examples
-          if_no_artifact_found: warn
-          workflow_conclusion: completed
 
       - name: Test randomly
-        timeout-minutes: 65
+        continue-on-error: true
+        timeout-minutes: 60
         run: |
           if [[ ${{matrix.meta}} == "tikv" ]]; then
             subdir=true
           else
             subdir=false
           fi
-          sudo -E LOG_LEVEL=WARNING SUBDIR=$subdir timeout 3600 .github/scripts/command/gateway-random.sh test_run_all || code=$?; if [[ $code -eq 124 ]]; then echo test timeout with $code && exit 0; else echo test failed with $code && exit $code; fi
+          sudo -E LOG_LEVEL=WARNING SUBDIR=$subdir .github/scripts/command/gateway-random.sh test_run_all 2>&1 | tee fsrand.log
+      
+      - name: check fsrand.log
+        if: always()
+        run: | 
+          grep "AssertionError" fsrand.log && exit 1 || true
 
       - name: Upload example database
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         if: always()
         with:
-          name: hypothesis-example-db
+          include-hidden-files: true
+          name: hypothesis-example-db-${{ matrix.meta }}
           path: .hypothesis/examples
 
       - name: check log

diff --git a/.github/workflows/mutate-test-sdk.yml b/.github/workflows/mutate-test-sdk.yml
@@ -92,7 +92,7 @@ jobs:
           cd -
 
       - name: Upload Pit Report
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: pit-reports
           path: sdk/java/target/pit-reports

diff --git a/.github/workflows/pysdk.yml b/.github/workflows/pysdk.yml
@@ -128,12 +128,12 @@ jobs:
           sudo META_URL=$meta_url python3 .github/scripts/pysdk/pysdk_test.py
 
       - name: Download example database
-        uses: dawidd6/action-download-artifact@v6
+        timeout-minutes: 5
+        continue-on-error: true
+        uses: actions/download-artifact@v4
         with:
-          name: hypothesis-example-db
+          name: hypothesis-example-db-${{ matrix.meta }}
           path: .hypothesis/examples
-          if_no_artifact_found: warn
-          workflow_conclusion: completed
 
       - name: Run file_test.py
         run: |
@@ -167,10 +167,11 @@ jobs:
           sudo USE_SDK=true META_URL=$meta_url python3 .github/scripts/hypo/fs.py 
 
       - name: Upload example database
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         if: always()
         with:
-          name: hypothesis-example-db
+          include-hidden-files: true
+          name: hypothesis-example-db-${{ matrix.meta }}
           path: .hypothesis/examples
 
       - name: upload coverage report

diff --git a/.github/workflows/vdbench.yml b/.github/workflows/vdbench.yml
@@ -98,9 +98,9 @@ jobs:
           GOCOVERDIR=$(pwd)/cover ./juicefs mount -d $meta_url /tmp/jfs --no-usage-report --cache-size 1024 --max-deletes 50
           vdbench/vdbench -f .github/workflows/resources/vdbench_long_run.conf -jn
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
-          name: output-long-run
+          name: output-long-run-${{ matrix.meta }}
           path: output
 
       - name: check vdbench log

diff --git a/.github/workflows/version_compatible_hypo.yml b/.github/workflows/version_compatible_hypo.yml
@@ -128,7 +128,7 @@ jobs:
 
       - name: Upload command log
         if: always()
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: ${{matrix.meta}}-${{matrix.old_juicefs_version}}.command.log
           path: ~/command.log