Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/sync: fix the bug where empty files are always synchronized #4223

Merged
merged 6 commits into from
Dec 4, 2023

Conversation

zhijian-pro
Copy link
Contributor

@zhijian-pro zhijian-pro commented Nov 30, 2023

close #4217

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (5b8610f) 55.58% compared to head (fd0da37) 55.68%.
Report is 4 commits behind head on main.

Files Patch % Lines
pkg/object/prefix.go 0.00% 6 Missing ⚠️
pkg/sync/sync.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4223      +/-   ##
==========================================
+ Coverage   55.58%   55.68%   +0.09%     
==========================================
  Files         154      154              
  Lines       39539    39569      +30     
==========================================
+ Hits        21978    22034      +56     
+ Misses      15104    15070      -34     
- Partials     2457     2465       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhijian-pro zhijian-pro requested a review from davies December 1, 2023 06:13
pkg/sync/sync.go Outdated Show resolved Hide resolved
@davies davies merged commit 1a82b80 into main Dec 4, 2023
34 checks passed
@davies davies deleted the fix-sync-empty branch December 4, 2023 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

should respect the permission of empty file when sync.
2 participants