Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: support using 'd' as the days unit in the duration flag #4246

Merged
merged 3 commits into from
Dec 12, 2023

Conversation

SandyXSD
Copy link
Contributor

@SandyXSD SandyXSD commented Dec 11, 2023

This PR takes over #4002

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (1dd17de) 55.70% compared to head (d34cea6) 55.67%.

Files Patch % Lines
cmd/flags.go 60.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4246      +/-   ##
==========================================
- Coverage   55.70%   55.67%   -0.03%     
==========================================
  Files         154      154              
  Lines       39569    39580      +11     
==========================================
- Hits        22042    22037       -5     
- Misses      15060    15075      +15     
- Partials     2467     2468       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davies davies merged commit 0211494 into main Dec 12, 2023
29 of 31 checks passed
@davies davies deleted the duration-days branch December 12, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants