Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk/python: use same bits of integer in all languages #5516

Merged
merged 17 commits into from
Jan 17, 2025
Merged

Conversation

CodingPoeta
Copy link
Contributor

#5503

Also: update the SDK function parameter list to ensure accurate data types.

@CodingPoeta CodingPoeta force-pushed the fix-pysdk-setxattr branch 3 times, most recently from 5f6ca5e to 02ec763 Compare January 6, 2025 11:35
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.91%. Comparing base (d329bb0) to head (9ff90e9).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5516      +/-   ##
==========================================
+ Coverage   54.50%   54.91%   +0.40%     
==========================================
  Files         165      166       +1     
  Lines       47877    48116     +239     
==========================================
+ Hits        26094    26421     +327     
+ Misses      18936    18828     -108     
- Partials     2847     2867      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CodingPoeta CodingPoeta force-pushed the fix-pysdk-setxattr branch 5 times, most recently from 21ff7bf to 14a3169 Compare January 8, 2025 04:26
@davies davies changed the title fix(pysdk): setxattr flags wrong type sdk/python: setxattr flags wrong type Jan 8, 2025
@CodingPoeta CodingPoeta changed the title sdk/python: setxattr flags wrong type sdk/python: fix setxattr flags wrong type Jan 8, 2025
@davies davies changed the title sdk/python: fix setxattr flags wrong type sdk/python: use same bits of integer in all languages Jan 8, 2025
@CodingPoeta CodingPoeta force-pushed the fix-pysdk-setxattr branch 3 times, most recently from 9d7e716 to 1ab5de3 Compare January 16, 2025 15:03
@CodingPoeta CodingPoeta force-pushed the fix-pysdk-setxattr branch 5 times, most recently from acaae46 to 0d88754 Compare January 16, 2025 17:07
@davies davies merged commit 1828455 into main Jan 17, 2025
54 of 56 checks passed
@davies davies deleted the fix-pysdk-setxattr branch January 17, 2025 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants