Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/sync: eliminate wasteful file store list in sync #5530

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

cmd/sync: eliminate wasteful file store list in sync #5530

wants to merge 1 commit into from

Conversation

YinhaoHu
Copy link
Contributor

@YinhaoHu YinhaoHu commented Jan 8, 2025

close #5434

@codecov Codecov
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 45.31%. Comparing base (52a48a2) to head (a645c51).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/sync/sync.go 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5530      +/-   ##
==========================================
- Coverage   54.81%   45.31%   -9.50%     
==========================================
  Files         165      164       -1     
  Lines       48086    47853     -233     
==========================================
- Hits        26356    21685    -4671     
- Misses      18851    23556    +4705     
+ Partials     2879     2612     -267

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

davies
davies reviewed Jan 9, 2025
View reviewed changes
pkg/sync/sync.go
@@ -1247,8 +1248,12 @@ func listCommonPrefix(store object.ObjectStorage, prefix string, cp chan object.
var nextToken string
var marker string
var hasMore bool
var thisListMaxResults int64 = maxResults
if strings.HasPrefix(store.String(), "file://") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do this for all the filesystem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davies davies davies left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize FileStore sync performance by reducing redundant directory scans
2 participants
@YinhaoHu @davies