-
Notifications
You must be signed in to change notification settings - Fork 997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gateway: add one more hierarchy to upload tmp/multiupload dir to reduce txn conflicts #5549
Conversation
91c784d
to
fb85f23
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5549 +/- ##
==========================================
- Coverage 50.57% 45.71% -4.87%
==========================================
Files 166 164 -2
Lines 48152 47873 -279
==========================================
- Hits 24353 21884 -2469
- Misses 21076 23349 +2273
+ Partials 2723 2640 -83 ☔ View full report in Codecov by Sentry. |
…ce txn conflicts Signed-off-by: Changxin Miao <[email protected]>
fb85f23
to
08885bd
Compare
This is a behavior change, I think we should introduce a parameter to enable it. |
The |
3224407
to
4bbe479
Compare
OK, updated Please review: |
…ompatibility reason Signed-off-by: Changxin Miao <[email protected]>
4bbe479
to
63bef7d
Compare
In the current gateway implementation, the
tmp/upload
directory is a flat structure, which can easily lead to concurrency conflicts under high concurrency. These conflicts severely impact performance and prevent the gateway from scaling.We can reduce conflicts in those large directories by adding a layer of hierarchy.