test: Fixes testsuite

- Replace createPartialMock function (deprecated) to getMockBuilder

Fixes facebookarchive#87

Test/Unit/Block/Pixel/HeadTest.php

@@ -29,7 +29,7 @@ class HeadTest extends \PHPUnit\Framework\TestCase
    *
    * @return void
    */
-    public function tearDown()
+    public function tearDown(): void
     {
     }
 
@@ -38,7 +38,7 @@ public function tearDown()
    *
    * @return void
    */
-    public function setUp()
+    public function setUp(): void
     {
 
         $this->context = $this->createMock(\Magento\Framework\View\Element\Template\Context::class);

Test/Unit/Controller/Adminhtml/Ajax/FbaamsettingsTest.php

@@ -25,7 +25,7 @@ class FbaamsettingsTest extends \PHPUnit\Framework\TestCase
    *
    * @return void
    */
-    public function tearDown()
+    public function tearDown(): void
     {
     }
 
@@ -34,7 +34,7 @@ public function tearDown()
    *
    * @return void
    */
-    public function setUp()
+    public function setUp(): void
     {
         $this->context = $this->createMock(\Magento\Backend\App\Action\Context::class);
         $this->resultJsonFactory = $this->createMock(\Magento\Framework\Controller\Result\JsonFactory::class);

Test/Unit/Controller/Adminhtml/Ajax/FbdeleteassetTest.php

@@ -25,7 +25,7 @@ class FbdeleteassetTest extends \PHPUnit\Framework\TestCase
      *
      * @return void
      */
-    public function tearDown()
+    public function tearDown(): void
     {
     }
 
@@ -34,7 +34,7 @@ public function tearDown()
      *
      * @return void
      */
-    public function setUp()
+    public function setUp(): void
     {
         $this->context = $this->createMock(\Magento\Backend\App\Action\Context::class);
         $this->resultJsonFactory = $this->createMock(\Magento\Framework\Controller\Result\JsonFactory::class);

Test/Unit/Controller/Adminhtml/Ajax/FbfeedpushTest.php

@@ -29,7 +29,7 @@ class FbfeedpushTest extends \PHPUnit\Framework\TestCase
      *
      * @return void
      */
-    public function tearDown()
+    public function tearDown(): void
     {
     }
 
@@ -38,7 +38,7 @@ public function tearDown()
      *
      * @return void
      */
-    public function setUp()
+    public function setUp(): void
     {
         $this->context = $this->createMock(\Magento\Backend\App\Action\Context::class);
         $this->resultJsonFactory = $this->createMock(\Magento\Framework\Controller\Result\JsonFactory::class);

Test/Unit/Controller/Adminhtml/Ajax/FbpixelTest.php

@@ -25,7 +25,7 @@ class FbpixelTest extends \PHPUnit\Framework\TestCase
      *
      * @return void
      */
-    public function tearDown()
+    public function tearDown(): void
     {
     }
 
@@ -34,7 +34,7 @@ public function tearDown()
      *
      * @return void
      */
-    public function setUp()
+    public function setUp(): void
     {
         $this->context = $this->createMock(\Magento\Backend\App\Action\Context::class);
         $this->resultJsonFactory = $this->createMock(\Magento\Framework\Controller\Result\JsonFactory::class);

Test/Unit/Controller/Adminhtml/Ajax/FbprofilesTest.php

@@ -25,7 +25,7 @@ class FbprofilesTest extends \PHPUnit\Framework\TestCase
      *
      * @return void
      */
-    public function tearDown()
+    public function tearDown(): void
     {
     }
 
@@ -34,7 +34,7 @@ public function tearDown()
      *
      * @return void
      */
-    public function setUp()
+    public function setUp(): void
     {
         $this->context = $this->createMock(\Magento\Backend\App\Action\Context::class);
         $this->resultJsonFactory = $this->createMock(\Magento\Framework\Controller\Result\JsonFactory::class);

Test/Unit/Controller/Adminhtml/Ajax/FbtokenTest.php

@@ -25,7 +25,7 @@ class FbtokenTest extends \PHPUnit\Framework\TestCase
      *
      * @return void
      */
-    public function tearDown()
+    public function tearDown(): void
     {
     }
 
@@ -34,7 +34,7 @@ public function tearDown()
      *
      * @return void
      */
-    public function setUp()
+    public function setUp(): void
     {
         $this->context = $this->createMock(\Magento\Backend\App\Action\Context::class);
         $this->resultJsonFactory = $this->createMock(\Magento\Framework\Controller\Result\JsonFactory::class);

Test/Unit/Cron/AAMSettingsCronTest.php

@@ -10,7 +10,7 @@
 use \Facebook\BusinessExtension\Helper\FBEHelper;
 use \Facebook\BusinessExtension\Cron\AAMSettingsCron;
 
-class EventIdGeneratorTest extends \PHPUnit\Framework\TestCase
+class AAMSettingsCronTest extends \PHPUnit\Framework\TestCase
 {
 
     protected $aamSettingsCron;
@@ -21,7 +21,7 @@ class EventIdGeneratorTest extends \PHPUnit\Framework\TestCase
    *
    * @return void
    */
-    public function tearDown()
+    public function tearDown(): void
     {
     }
 
@@ -30,7 +30,7 @@ public function tearDown()
    *
    * @return void
    */
-    public function setUp()
+    public function setUp(): void
     {
         $this->fbeHelper = $this->createMock(\Facebook\BusinessExtension\Helper\FBEHelper::class);
         $this->aamSettingsCron = new \Facebook\BusinessExtension\Cron\AAMSettingsCron($this->fbeHelper);

Test/Unit/Cron/CategorySyncCronTest.php

@@ -10,7 +10,7 @@
 use Facebook\BusinessExtension\Model\Feed\CategoryCollection;
 use Facebook\BusinessExtension\Model\System\Config as SystemConfig;
 
-class CronRunTest extends \PHPUnit\Framework\TestCase
+class CategorySyncCronTest extends \PHPUnit\Framework\TestCase
 {
 
     protected $categorySyncCron;
@@ -23,7 +23,7 @@ class CronRunTest extends \PHPUnit\Framework\TestCase
      *
      * @return void
      */
-    public function tearDown()
+    public function tearDown(): void
     {
     }
 
@@ -32,7 +32,7 @@ public function tearDown()
      *
      * @return void
      */
-    public function setUp()
+    public function setUp(): void
     {
         $this->fbeHelper = $this->createMock(FBEHelper::class);
         $this->categoryCollection = $this->createMock(CategoryCollection::class);
@@ -51,7 +51,7 @@ public function setUp()
      */
     public function testNCronDisabled()
     {
-        $this->systemConfig->method('isActiveCollectionsSync')->willReturn(false);
+        $this->systemConfig->method('isActiveCatalogSync')->willReturn(false);
 
         $result = $this->categorySyncCron->execute();
 
@@ -65,7 +65,7 @@ public function testNCronDisabled()
      */
     public function testNCronEnabled()
     {
-        $this->systemConfig->method('isActiveCollectionsSync')->willReturn(true);
+        $this->systemConfig->method('isActiveCatalogSync')->willReturn(true);
 
         $result = $this->categorySyncCron->execute();
 

Test/Unit/Helper/AAMFieldsExtractorHelperTest.php

@@ -29,7 +29,7 @@ class AAMFieldsExtractorHelperTest extends TestCase
    *
    * @return void
    */
-    public function setUp()
+    public function setUp(): void
     {
         $this->fbeHelper = $this->createMock(FBEHelper::class);
         $this->magentoDataHelper = $this->createMock(MagentoDataHelper::class);

Test/Unit/Helper/EventIdGeneratorTest.php

@@ -15,7 +15,7 @@ class EventIdGeneratorTest extends TestCase
    *
    * @return void
    */
-    public function tearDown()
+    public function tearDown(): void
     {
     }
 
@@ -24,7 +24,7 @@ public function tearDown()
    *
    * @return void
    */
-    public function setUp()
+    public function setUp(): void
     {
     }
 

Test/Unit/Helper/FBEHelperTest.php

@@ -46,7 +46,7 @@ class FBEHelperTest extends \PHPUnit\Framework\TestCase
    *
    * @return void
    */
-    public function tearDown()
+    public function tearDown(): void
     {
     }
 
@@ -55,7 +55,7 @@ public function tearDown()
    *
    * @return void
    */
-    public function setUp()
+    public function setUp(): void
     {
         $this->context = $this->createMock(Context::class);
         $this->objectManagerInterface = $this->createMock(ObjectManagerInterface::class);

Test/Unit/Helper/ServerEventFactoryTest.php

@@ -16,7 +16,7 @@ class ServerEventFactoryTest extends TestCase
    *
    * @return void
    */
-    public function tearDown()
+    public function tearDown(): void
     {
     }
 
@@ -25,7 +25,7 @@ public function tearDown()
    *
    * @return void
    */
-    public function setUp()
+    public function setUp(): void
     {
     }
 

Test/Unit/Helper/ServerSideHelperTest.php

@@ -25,7 +25,7 @@ class ServerSideHelperTest extends TestCase
    *
    * @return void
    */
-    public function tearDown()
+    public function tearDown(): void
     {
     }
 
@@ -34,7 +34,7 @@ public function tearDown()
    *
    * @return void
    */
-    public function setUp()
+    public function setUp(): void
     {
         $this->fbeHelper = $this->createMock(FBEHelper::class);
         $this->aamFieldsExtractorHelper =

Test/Unit/Observer/AddToCartTest.php

@@ -21,7 +21,7 @@ class AddToCartTest extends CommonTest
    *
    * @return void
    */
-    public function tearDown()
+    public function tearDown(): void
     {
     }
 
@@ -30,7 +30,7 @@ public function tearDown()
    *
    * @return void
    */
-    public function setUp()
+    public function setUp(): void
     {
         parent::setUp();
         $this->request = $this->createMock(RequestInterface::class);

Test/Unit/Observer/CommonTest.php

@@ -9,6 +9,7 @@
 use Facebook\BusinessExtension\Helper\FBEHelper;
 use Facebook\BusinessExtension\Helper\MagentoDataHelper;
 use Facebook\BusinessExtension\Helper\ServerSideHelper;
+use Facebook\BusinessExtension\Model\System\Config as SystemConfig;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 use PHPUnit\Framework\TestCase;
 
@@ -19,6 +20,8 @@ abstract class CommonTest extends TestCase
 
     protected $fbeHelper;
 
+    protected $systemConfig;
+
     protected $objectManager;
 
     protected $serverSideHelper;
@@ -30,7 +33,7 @@ abstract class CommonTest extends TestCase
    *
    * @return void
    */
-    public function tearDown()
+    public function tearDown(): void
     {
     }
 
@@ -39,7 +42,7 @@ public function tearDown()
    *
    * @return void
    */
-    public function setUp()
+    public function setUp(): void
     {
         $this->fbeHelper = $this->createMock(FBEHelper::class);
         $this->magentoDataHelper = $this->createMock(MagentoDataHelper::class);
@@ -55,6 +58,9 @@ public function setUp()
         $this->fbeHelper->method('getAccessToken')->willReturn('');
         $this->fbeHelper->method('getPixelId')->willReturn('123');
         $this->magentoDataHelper->method('getCurrency')->willReturn('USD');
+
+        $this->systemConfig = $this->createMock(SystemConfig::class);
+        $this->systemConfig->method('isActiveCatalogSync')->willReturn(true);
     }
 
     public function assertEqualsCustomData($customDataArray, $customData)

Test/Unit/Observer/InitiateCheckoutTest.php

@@ -18,7 +18,7 @@ class InitiateCheckoutTest extends CommonTest
    *
    * @return void
    */
-    public function tearDown()
+    public function tearDown(): void
     {
     }
 
@@ -27,7 +27,7 @@ public function tearDown()
    *
    * @return void
    */
-    public function setUp()
+    public function setUp(): void
     {
         parent::setUp();
         $this->initiateCheckoutObserver =

Test/Unit/Observer/ProcessCategoryAfterDeleteEventObserverTest.php

@@ -28,7 +28,7 @@ class ProcessCategoryAfterDeleteEventObserverTest extends CommonTest
      *
      * @return void
      */
-    public function tearDown()
+    public function tearDown(): void
     {
     }
 
@@ -37,16 +37,23 @@ public function tearDown()
      *
      * @return void
      */
-    public function setUp()
+    public function setUp(): void
     {
         parent::setUp();
         $this->_category = $this->createMock(Category::class);
-        $event = $this->createPartialMock(Event::class, ['getCategory']);
+        /** @var Event|MockObject */
+        $event = $this->getMockBuilder(Event::class)
+            ->disableOriginalConstructor()
+            ->addMethods(['getCategory'])
+            ->getMock();
         $event->expects($this->once())->method('getCategory')->will($this->returnValue($this->_category));
         $this->_eventObserverMock = $this->createMock(\Magento\Framework\Event\Observer::class);
         $this->_eventObserverMock->expects($this->once())->method('getEvent')->will($this->returnValue($event));
         $this->processCategoryAfterDeleteEventObserver =
-            new \Facebook\BusinessExtension\Observer\ProcessCategoryAfterDeleteEventObserver($this->fbeHelper);
+            new \Facebook\BusinessExtension\Observer\ProcessCategoryAfterDeleteEventObserver(
+                $this->fbeHelper,
+                $this->systemConfig
+            );
     }
 
     public function testExcution()