Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove canister status sync indicator #1116

Merged
merged 1 commit into from
Jan 19, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<script lang="ts">
import { isNullish } from '@dfinity/utils';
import { fade, blur } from 'svelte/transition';

Check warning on line 3 in src/frontend/src/lib/components/canister/CanisterIndicator.svelte

View workflow job for this annotation

GitHub Actions / lint

'blur' is defined but never used. Allowed unused vars must match /^_/u
import IconSync from '$lib/components/icons/IconSync.svelte';

Check warning on line 4 in src/frontend/src/lib/components/canister/CanisterIndicator.svelte

View workflow job for this annotation

GitHub Actions / lint

'IconSync' is defined but never used. Allowed unused vars must match /^_/u
import { i18n } from '$lib/stores/i18n.store';
import type { CanisterData, CanisterStatus, CanisterSyncStatus } from '$lib/types/canister';

Expand All @@ -10,7 +10,7 @@
sync?: CanisterSyncStatus | undefined;
}

let { data = undefined, sync }: Props = $props();

Check warning on line 13 in src/frontend/src/lib/components/canister/CanisterIndicator.svelte

View workflow job for this annotation

GitHub Actions / lint

'sync' is assigned a value but never used. Allowed unused vars must match /^_/u

let warning: boolean = $derived(data?.warning?.cycles === true);

Expand All @@ -19,8 +19,6 @@

{#if isNullish(status)}
<div in:fade></div>
{:else if sync === 'syncing'}
<span class="spinner" in:blur><IconSync size="16px" /> </span>
{:else if warning || status === 'stopping'}
<div class="warning" in:fade aria-label={$i18n.canisters.warning_indicator}></div>
{:else if status === 'stopped'}
Expand Down Expand Up @@ -53,8 +51,4 @@
.stopped {
background: var(--color-error);
}

.spinner {
height: 16px;
}
</style>
Loading