Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

➖ Hide scrollbar in PrimarySidebar #502

Closed
wants to merge 1 commit into from

Conversation

jnywong
Copy link
Contributor

@jnywong jnywong commented Nov 25, 2024

Copy link

changeset-bot bot commented Nov 25, 2024

⚠️ No Changeset found

Latest commit: 2624fe2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@agoose77
Copy link
Collaborator

agoose77 commented Nov 25, 2024

Thanks for this PR @jnywong!

I need to do some due diligence to think through what the a11y ramifications of making this change will be. I'll circle back round once I know more!

@jnywong
Copy link
Contributor Author

jnywong commented Nov 25, 2024

Good shout regarding a11y principles! Happy to help with thinking around that.

@jnywong
Copy link
Contributor Author

jnywong commented Nov 26, 2024

Okay yeah, this change is not very a11y-friendly!

Happy to repurpose this into making the scrollbar theme change when switching to dark mode, but need some pointers on where to start because the light/dark mode theme switcher looks a little more complicated to contribute to at first glance.

@jnywong jnywong closed this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants