Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔘 Add support for buttons #521

Merged
merged 17 commits into from
Jan 27, 2025
Merged

🔘 Add support for buttons #521

merged 17 commits into from
Jan 27, 2025

Conversation

jnywong
Copy link
Contributor

@jnywong jnywong commented Jan 13, 2025

Add LinkOrButton renderer

Co-authored-by: Angus Hollands <[email protected]>
Copy link

changeset-bot bot commented Jan 13, 2025

🦋 Changeset detected

Latest commit: cb9edcb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
myst-to-react Patch
@myst-theme/styles Patch
@myst-theme/providers Patch
@myst-theme/frontmatter Patch
@myst-theme/diagrams Patch
@myst-theme/jupyter Patch
@myst-theme/site Patch
@myst-theme/common Patch
@myst-theme/icons Patch
@myst-theme/search Patch
@myst-theme/search-minisearch Patch
@myst-theme/book Patch
@myst-theme/article Patch
myst-demo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jnywong jnywong changed the title Ref: https://github.com/2i2c-org/infrastructure/issues/5346 Add support for buttons Jan 13, 2025
@jnywong jnywong marked this pull request as draft January 13, 2025 11:32
@jnywong jnywong marked this pull request as ready for review January 17, 2025 15:06
@rowanc1 rowanc1 changed the title Add support for buttons 🔘 Add support for buttons Jan 22, 2025
@choldgraf
Copy link
Contributor

+1 on getting these in and released so we can kick the tires on them and iterate from there. We can put these into next.jupyterbook.org to see how that goes.

@agoose77
Copy link
Collaborator

Sounds good! @jnywong is going to write up some small docs, and then she can merge!

@agoose77
Copy link
Collaborator

@rowanc1 this is blocked until we make a new first of myst-ext-button (it's needed by the demo component). Any suggestions on procedure for unblocking?

@rowanc1
Copy link
Member

rowanc1 commented Jan 27, 2025

This is now published and ebp-bot has access to work in CI.

@agoose77
Copy link
Collaborator

Kicking CI

@agoose77 agoose77 closed this Jan 27, 2025
@agoose77 agoose77 reopened this Jan 27, 2025
@agoose77 agoose77 merged commit c2db8fb into jupyter-book:main Jan 27, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a button for call to action and noticeable links
4 participants