Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new analytics filter payments #2019

Merged
merged 12 commits into from
Jan 8, 2025
Merged

Conversation

sagarnaikjuspay
Copy link
Contributor

@sagarnaikjuspay sagarnaikjuspay commented Jan 6, 2025

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

new analytics payment page currrency filters
Screenshot 2025-01-06 at 6 32 38 PM
image
Screenshot 2025-01-06 at 6 32 59 PM
Screenshot 2025-01-06 at 6 33 13 PM

Motivation and Context

How did you test it?

then all currency is passed no filter is been passed to BE and it would show as USD* and other if any currency selected the api calls happens by passing thefilter in payload and curresposngin currency value should shown

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@sagarnaikjuspay sagarnaikjuspay added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed analytics labels Jan 6, 2025
@sagarnaikjuspay sagarnaikjuspay self-assigned this Jan 6, 2025
@sagarnaikjuspay sagarnaikjuspay requested a review from a team as a code owner January 6, 2025 13:07
Copy link

Review changes with  SemanticDiff

@sagarnaikjuspay sagarnaikjuspay linked an issue Jan 6, 2025 that may be closed by this pull request
JeevaRamu0104
JeevaRamu0104 previously approved these changes Jan 7, 2025
gitanjli525
gitanjli525 previously approved these changes Jan 7, 2025
@prajwalnl0 prajwalnl0 added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit 90c0be2 Jan 8, 2025
5 of 6 checks passed
@prajwalnl0 prajwalnl0 deleted the new-analytics-filter-payments branch January 8, 2025 09:48
@github-actions github-actions bot removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed analytics labels Jan 8, 2025
@github-actions github-actions bot added the Closed Applied to issues or pull requests that have been successfully resolved or completed label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Applied to issues or pull requests that have been successfully resolved or completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new analytics filters componet level changes for payments
4 participants