feat: Recon screens #2052
Open
feat: Recon screens #2052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…center into recon-order-data-screen
…ch-control-center into recon-order-data-screen
…ch-control-center into recon-order-data-screen
…center into recon-order-data-screen
…yperswitch-control-center into recon-order-data-screen
| @@ -3,7 +3,7 @@ primary_color="#006DF9" | |||
| primary_hover_color="#005ED6" | |||
| sidebar_color="#242F48" | |||
| [default.endpoints] | |||
| api_url="http://localhost:9000/api" | |||
| api_url="http://localhost:8000/api" | |||
| sdk_url="http://localhost:9050/HyperLoader.js" | |||
There was a problem hiding this comment.
this 9050 port number also need to point to local host port number right ??
| @@ -16,14 +16,14 @@ dss_certificate_url="" | |||
| [default.features] | |||
| test_live_toggle=false | |||
| is_live_mode=false | |||
| email=false | |||
| email=true | |||
There was a problem hiding this comment.
isn't it be false by default
| authorization={userHasAccess(~groupAccess=ConnectorsManage)} | ||
| onClick={_ => setSelectedProcessor(_ => processorName)} | ||
| key={i->string_of_int} | ||
| className={`${selectedProcessor === processorName |
There was a problem hiding this comment.
this conditional css can be stored in the external variable and used diresctly here
| buttonType={Secondary} | ||
| onClick={_ => setCurrentStep(prev => getPreviousStep(prev))} | ||
| /> | ||
| // <Button |
There was a problem hiding this comment.
this commented code maybe removed if its not required
| customButtonStyle="rounded w-90-px" | ||
| buttonType={Secondary} | ||
| onClick={_ => setCurrentStep(prev => getPreviousStep(prev))} | ||
| text="Done" customButtonStyle="rounded w-90-px" buttonType={Primary} onClick={onSubmit} | ||
| /> | ||
| | (true, true) => <div /> |
There was a problem hiding this comment.
React.null also can be used in the place of empty div
| let {userInfo: {merchantId}} = React.useContext(UserInfoProvider.defaultContext) | ||
| let (url, body) = getReconReports(~merchantId) | ||
|
|
||
| async _ => { |
There was a problem hiding this comment.
can be ()=>{} this form right is arguments are not passed
webpack.dev.js
Outdated
| pathRewrite: { "^/api": "" }, | ||
| changeOrigin: true, | ||
| }, | ||
| // "/recon-settlement-api": { |
There was a problem hiding this comment.
do we need this commented code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Motivation and Context
How did you test it?
Where to test it?
Checklist
npm run re:build