Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Org Sidebar #2087

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

feat: Org Sidebar #2087

wants to merge 34 commits into from

Conversation

kanikabansal-juspay
Copy link
Collaborator

@kanikabansal-juspay kanikabansal-juspay commented Jan 19, 2025

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Screen.Recording.2025-01-28.at.12.28.41.PM.mov

For adding a new org ( Tenant User )

Screenshot 2025-01-28 at 12 30 55 PM

Motivation and Context

New Design System adoption

How did you test it?

  • Turn on the dev_org_sidebar feature flag.
  • Check for organisation changes.

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@kanikabansal-juspay kanikabansal-juspay added the C-feature Category: Feature request or enhancement label Jan 19, 2025
@kanikabansal-juspay kanikabansal-juspay self-assigned this Jan 19, 2025
@kanikabansal-juspay kanikabansal-juspay requested a review from a team as a code owner January 19, 2025 14:05
Copy link

semanticdiff-com bot commented Jan 19, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  public/hyperswitch/icons/solid.svg  100% smaller
  config/config.toml Unsupported file format
  src/components/InlineEditInput.res Unsupported file format
  src/components/InlineEditInput.resi Unsupported file format
  src/entryPoints/FeatureFlagUtils.res Unsupported file format
  src/entryPoints/HyperSwitchApp.res Unsupported file format
  src/screens/Helpers/HelperComponents.res Unsupported file format
  src/screens/OMPSwitch/OMPSwitchHelper.res Unsupported file format
  src/screens/Sidebar/OrgSidebar.res Unsupported file format
  src/screens/Sidebar/Sidebar.res Unsupported file format
  src/screens/Sidebar/SidebarSwitch.res Unsupported file format

@kanikabansal-juspay kanikabansal-juspay linked an issue Jan 21, 2025 that may be closed by this pull request
@@ -105,6 +106,9 @@ let make = () => {
<div className={`h-screen flex flex-col`}>
<div className="flex relative overflow-auto h-screen ">
<RenderIf condition={screenState === Success}>
<RenderIf condition={devOrgSidebar}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be moved out of renderIf

->Array.slice(~start=0, ~end=index + 1)
->Array.filter(org => org.name == org.id)
->Array.length
`O${count->Int.toString}`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it can be count+1

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indexing will then start from O2 and not O1.

})
->Array.mapWithIndex((org, i) => {
<OrgTile
orgID={org.id}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass key to avoid

Copy link
Collaborator

@JeevaRamu0104 JeevaRamu0104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add new org icon is not centred

@kanikabansal-juspay
Copy link
Collaborator Author

add new org icon is not centred

Added the updated image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: Feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Org Sidebar ( New Design System)
3 participants