-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Org Sidebar #2087
base: main
Are you sure you want to change the base?
feat: Org Sidebar #2087
Conversation
Changed Files
|
…enter into org-sidebar
src/entryPoints/HyperSwitchApp.res
Outdated
@@ -105,6 +106,9 @@ let make = () => { | |||
<div className={`h-screen flex flex-col`}> | |||
<div className="flex relative overflow-auto h-screen "> | |||
<RenderIf condition={screenState === Success}> | |||
<RenderIf condition={devOrgSidebar}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be moved out of renderIf
->Array.slice(~start=0, ~end=index + 1) | ||
->Array.filter(org => org.name == org.id) | ||
->Array.length | ||
`O${count->Int.toString}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it can be count+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indexing will then start from O2 and not O1.
}) | ||
->Array.mapWithIndex((org, i) => { | ||
<OrgTile | ||
orgID={org.id} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pass key to avoid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add new org icon is not centred
Added the updated image. |
Type of Change
Description
Screen.Recording.2025-01-28.at.12.28.41.PM.mov
For adding a new org ( Tenant User )
Motivation and Context
New Design System adoption
How did you test it?
Where to test it?
Checklist
npm run re:build