Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Refactor modal warning icon in Smart and volume based routing #2143

Merged
merged 3 commits into from
Jan 28, 2025
Merged

fix: Refactor modal warning icon in Smart and volume based routing #2143

merged 3 commits into from
Jan 28, 2025
+34 −5

Conversation

Muditbhatia12
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

image
Put the correct warning icon in Volume Based Routing and Smart routing tabs when configure rule is clicked.
Additionally changed the Modal tex.

Motivation and Context

How did you test it?

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@Muditbhatia12 Muditbhatia12 self-assigned this Jan 27, 2025
@Muditbhatia12 Muditbhatia12 requested a review from a team as a code owner January 27, 2025 14:06
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Jan 27, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  public/hyperswitch/icons/solid.svg  0% smaller
  src/screens/Routing/CustomModal.res Unsupported file format
  src/screens/Routing/VolumeSplitRouting.res Unsupported file format
  src/screens/RoutingRevamp/AdvancedRouting.res Unsupported file format

@Muditbhatia12 Muditbhatia12 added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jan 27, 2025
@Muditbhatia12 Muditbhatia12 linked an issue Jan 27, 2025 that may be closed by this pull request
[BUG] Warning icon not visible in Volume based routing and Smart Routing Tab #2144
Closed
2 tasks
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jan 27, 2025
@Muditbhatia12 Muditbhatia12 removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jan 28, 2025
@Muditbhatia12 Muditbhatia12 changed the title fix:Warning icon not showing in Smart routing and Volume based routing modal fix:Warning icon in Smart routing and Volume based routing modal Jan 28, 2025
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jan 28, 2025
@Muditbhatia12 Muditbhatia12 removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jan 28, 2025
@Muditbhatia12 Muditbhatia12 changed the title fix:Warning icon in Smart routing and Volume based routing modal fix:Smart routing and Volume based routing modal warning icon Jan 28, 2025
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jan 28, 2025
@Muditbhatia12 Muditbhatia12 changed the title fix:Smart routing and Volume based routing modal warning icon fix:Smart routing Volume based routing modal warning icon Jan 28, 2025
@Muditbhatia12 Muditbhatia12 added C-bug Category: Bug and removed S-conventions-not-followed Status: This PR does not follow contributing guidelines labels Jan 28, 2025
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jan 28, 2025
@Muditbhatia12 Muditbhatia12 removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jan 28, 2025
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jan 28, 2025
@Muditbhatia12 Muditbhatia12 changed the title fix:Smart routing Volume based routing modal warning icon fix:Refactor modal warning icon in Smart and volume based routing Jan 28, 2025
@Muditbhatia12 Muditbhatia12 removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jan 28, 2025
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jan 28, 2025
@Muditbhatia12 Muditbhatia12 changed the title fix:Refactor modal warning icon in Smart and volume based routing fix: Refactor modal warning icon in Smart and volume based routing Jan 28, 2025
@github-actions github-actions bot added S-conventions-not-followed Status: This PR does not follow contributing guidelines and removed S-conventions-not-followed Status: This PR does not follow contributing guidelines labels Jan 28, 2025
@Muditbhatia12 Muditbhatia12 removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jan 28, 2025
@prajwalnl0 prajwalnl0 added this pull request to the merge queue Jan 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 28, 2025
@prajwalnl0 prajwalnl0 added this pull request to the merge queue Jan 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 28, 2025
@prajwalnl0 prajwalnl0 added this pull request to the merge queue Jan 28, 2025
Merged via the queue into main with commit 2db22fd Jan 28, 2025
10 of 12 checks passed
@prajwalnl0 prajwalnl0 deleted the routing-warning-icon-change branch January 28, 2025 16:06
@github-actions github-actions bot added Closed Applied to issues or pull requests that have been successfully resolved or completed and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-bug Category: Bug labels Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeevaRamu0104 JeevaRamu0104 JeevaRamu0104 approved these changes

@gitanjli525 gitanjli525 gitanjli525 approved these changes

Assignees

@Muditbhatia12 Muditbhatia12

Labels
Closed Applied to issues or pull requests that have been successfully resolved or completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Warning icon not visible in Volume based routing and Smart Routing Tab
4 participants
@Muditbhatia12 @gitanjli525 @JeevaRamu0104 @prajwalnl0