Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Search text being sent in payload even when search field is cleared #2194

Merged
merged 2 commits into from
Feb 5, 2025
Merged

fix: Search text being sent in payload even when search field is cleared #2194

merged 2 commits into from
Feb 5, 2025

Conversation

Muditbhatia12
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

payments-list-bug-fixed.mov

Motivation and Context

#2161

How did you test it?

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@Muditbhatia12 Muditbhatia12 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-bug Category: Bug labels Feb 4, 2025
@Muditbhatia12 Muditbhatia12 self-assigned this Feb 4, 2025
@Muditbhatia12 Muditbhatia12 requested a review from a team as a code owner February 4, 2025 07:43
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with  SemanticDiff

@Muditbhatia12 Muditbhatia12 linked an issue Feb 4, 2025 that may be closed by this pull request
[BUG] ID is sent in API payload even when search field is cleared #2161
Closed
@Muditbhatia12 Muditbhatia12 changed the title fix:id being sent in payload even when search field is cleared fix: Id being sent in payload even when search field is cleared Feb 4, 2025
@github-actions github-actions bot added S-conventions-not-followed Status: This PR does not follow contributing guidelines and removed S-conventions-not-followed Status: This PR does not follow contributing guidelines labels Feb 4, 2025
@Muditbhatia12 Muditbhatia12 changed the title fix: Id being sent in payload even when search field is cleared fix: Search text being sent in payload even when search field is cleared Feb 4, 2025
@JeevaRamu0104 JeevaRamu0104 added this pull request to the merge queue Feb 5, 2025
Merged via the queue into main with commit fcc23df Feb 5, 2025
11 of 12 checks passed
@JeevaRamu0104 JeevaRamu0104 deleted the payments-list-bug branch February 5, 2025 06:29
@github-actions github-actions bot added Closed Applied to issues or pull requests that have been successfully resolved or completed and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-bug Category: Bug labels Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susrithasabbini susrithasabbini susrithasabbini approved these changes

@JeevaRamu0104 JeevaRamu0104 JeevaRamu0104 approved these changes

@kanikabansal-juspay kanikabansal-juspay kanikabansal-juspay approved these changes

Assignees

@Muditbhatia12 Muditbhatia12

Labels
Closed Applied to issues or pull requests that have been successfully resolved or completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] ID is sent in API payload even when search field is cleared
4 participants
@Muditbhatia12 @susrithasabbini @JeevaRamu0104 @kanikabansal-juspay