feat(merchant_account): Add list multiple merchants in MerchantAccountInterface
#3220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThisIsMani
requested review from
a team,
SanchithHegde,
Narayanbhat166 and
racnan
ThisIsMani
added
A-framework
| let merchant_accounts = futures::future::try_join_all( | ||
| encrypted_merchant_accounts | ||
| .into_iter() | ||
| .zip(merchant_key_stores.iter()) |
There was a problem hiding this comment.
How is the order ensured here? what if one of the merchant account or key stores are missing and that disrupts the mapping?
Narayanbhat166
previously approved these changes
Jan 2, 2024
SanchithHegde
previously approved these changes
Jan 2, 2024
ThisIsMani
dismissed stale reviews from SanchithHegde and Narayanbhat166
via
3c0f0d4
SanchithHegde
approved these changes
Jan 2, 2024
Narayanbhat166
approved these changes
Jan 5, 2024
pixincreate
added a commit
that referenced
this pull request
Jan 8, 2024
* 'main' of github.com:juspay/hyperswitch: fix(connector): [Stripe] Deserialization Error while parsing Dispute Webhook Body (#3256) refactor(euclid_wasm): Update wasm config (#3222) fix(analytics): added response to the connector outgoing event (#3129) fix(analytics): fixed response code to 501 (#3119) fix(connector): [NMI] Populating `ErrorResponse` with required fields and Mapping `connector_response_reference_id` (#3214) feat(merchant_account): Add list multiple merchants in `MerchantAccountInterface` (#3220) feat: include version number in response headers and on application startup (#3045) chore: address Rust 1.75 clippy lints (#3231) feat: add deep health check (#3210) feat(analytics): adding outgoing webhooks kafka event (#3140) refactor: address panics due to indexing and slicing (#3233) fix(users): Fix wrong redirection url in magic link (#3217) fix(user): add integration_completed enum in metadata type (#3245) chore(version): v1.106.1 fix(connector): [iatapay] change refund amount (#3244) chore(version): v1.106.0 test(postman): update postman collection files fix(core): fix recurring mandates flow for cyber source (#3224) chore: fix channel handling for consumer workflow loop (#3223)
ThisIsMani
added a commit
that referenced
this pull request
Jan 9, 2024
…ntInterface` (#3220) Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Add ability to get multiple merchant accounts at once from db with a list of
merchant_ids.Additional Changes
Motivation and Context
This feature is needed for users module, where we need to fetch the details of all the merchants that a particular user is part of.
How did you test it?
Postman, by changing a api to use this feature.
Currently it is not testable with the deployed version as there is no API which currently uses this.
Checklist
cargo +nightly fmt --allcargo clippy