feat: add deep health check for scheduler #3304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chethan-rao
added
A-process-tracker
5 tasks
Chethan-rao
force-pushed
the
scheduler-health-checks
branch
from
7d0cd6e to
14de558
Compare
NishantJoshi00
previously approved these changes
Jan 12, 2024
SanchithHegde
previously approved these changes
Jan 12, 2024
Chethan-rao
force-pushed
the
scheduler-health-checks
branch
from
51aea30 to
2e83aed
Compare
dracarys18
requested changes
Jan 31, 2024
SanchithHegde
approved these changes
Jan 31, 2024
dracarys18
approved these changes
Jan 31, 2024
NishantJoshi00
approved these changes
Feb 1, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
SanchithHegde
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR adds support for performing a deeper health check of the scheduler which includes:
Database connection check with read, write and delete queries (Added support for database transaction too)
Redis connection check with set, get and delete key (Set key with expiry of 30sec)
The deep health check API returns a 200 status code if all the components are in good health, but returns 500 if at least one component's health is down
Additional Changes
Motivation and Context
How did you test it?
/health/health/ready'health/readywith some db errorCannot be tested on sandbox as the endpoint is not exposed
Checklist
cargo +nightly fmt --allcargo clippy