-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(payment_methods): pass required_billing_contact_fields
field in /session
call based on dynamic fields
#4601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
required_billing_contact_fields
field in apple pay seession call based on dynamic fields
…/juspay/hyperswitch into apple_pay/billing-dynamic-fields
required_billing_contact_fields
field in apple pay seession call based on dynamic fieldsrequired_billing_contact_fields
field in apple pay session call based on dynamic fields
…usiness profile config
…/juspay/hyperswitch into apple_pay/billing-dynamic-fields
required_billing_contact_fields
field in apple pay session call based on dynamic fieldsrequired_billing_contact_fields
field in /session
call based on dynamic fields
…le_pay/billing-dynamic-fields
…le_pay/billing-dynamic-fields
Narayanbhat166
approved these changes
May 13, 2024
sai-harsha-vardhan
approved these changes
May 13, 2024
srujanchikke
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This change is required as part of the one click checkout where in which we expect apple pay to collect the billing details from the customer and pass it in the confirm call with the
payment_data
.In order for apple pay to collect the billing details from customer we need to pass
"requiredBillingContactFields": ["postalAddress"]
in the/session
call. Hence we need to have a validation in the backend that checks for the dynamic fields for a specific connector and pass therequired_billing_contact_fields
to sdk.Additional Changes
Motivation and Context
How did you test it?
-> Create a MCA for stripe
-> Apple pay payment create with confirm false
-> Since no dynamic fields was not added for stripe the
![image](https://private-user-images.githubusercontent.com/83439957/329176076-e4708058-ca0f-4d9c-8cc9-032097d9a5f1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NzEyNDksIm5iZiI6MTczOTY3MDk0OSwicGF0aCI6Ii84MzQzOTk1Ny8zMjkxNzYwNzYtZTQ3MDgwNTgtY2EwZi00ZDljLThjYzktMDMyMDk3ZDlhNWYxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDAxNTU0OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWFhYjRkOTQwZDA3NmVlNzZkMjI3YzhkYzhmNzM3NmRkMzRiOWZkZGI1ZmIxYzcwZTMyZjc3NTdhYjBiMGVmZDkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.gj_Yd0MBqo-WeF67IEz65FuKkfY8tjqMUuOaWUkS87M)
required_billing_contact_fields
isnull
-> Create MCA create for cybersource
-> Apple pay payment create with confirm false
-> Session call having the
![image](https://private-user-images.githubusercontent.com/83439957/329177918-e9d7a960-7d79-42a7-bbb6-4776cadc8fd5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NzEyNDksIm5iZiI6MTczOTY3MDk0OSwicGF0aCI6Ii84MzQzOTk1Ny8zMjkxNzc5MTgtZTlkN2E5NjAtN2Q3OS00MmE3LWJiYjYtNDc3NmNhZGM4ZmQ1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDAxNTU0OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNjNjM1ZmRlZDNiNTdkZjViNGJiODJhNmM5MGUzMTlmM2Q3NDRkZjZjMTVjNWY2OGI4YTQ0ZjhlNGM0ZTlmYTEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.HBL71F2EyJbIjvEJnTKWIYO4yFKQi54cpu_gI6cfev8)
required_billing_contact_fields
being passed as the dynamic fields are presentChecklist
cargo +nightly fmt --all
cargo clippy