feat(connector): [Novalnet] Add zero auth mandate #6631

cookieg13 · 2024-11-21T11:30:40Z

Type of Change

Description

Added zero auth mandates for Novalnet
Made changes so that create_webhook_url fn can accept merchant_connector_account_id instead of connector_name

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Zero auth mandate for novalnet
Note:
Skipping no3ds test cases as it is not supported by novalnet cc: @Likhin Bopanna

Tested manually
https://docs.google.com/document/d/1i4SSX837Dh9ipfOz24bDwJF8osR_UPmfPLWUbLP3bh0/edit?usp=sharing

Webhooks
Webhooks working as expected for /payments. Tested locally.

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

semanticdiff-com · 2024-11-21T11:30:43Z

Review changes with

Changed Files

File	Status
crates/router/src/core/payments.rs	48% smaller
crates/hyperswitch_connectors/src/connectors/novalnet/transformers.rs	4% smaller
crates/hyperswitch_connectors/src/connectors/novalnet.rs	1% smaller
crates/hyperswitch_connectors/src/utils.rs	0% smaller
crates/hyperswitch_domain_models/src/router_request_types.rs	0% smaller
crates/router/src/core/payments/helpers.rs	0% smaller
crates/router/src/core/payments/transformers.rs	0% smaller
crates/router/src/core/relay/utils.rs	0% smaller
crates/router/src/core/utils.rs	0% smaller
cypress-tests/cypress/e2e/PaymentUtils/Novalnet.js	0% smaller

crates/hyperswitch_connectors/src/connectors/novalnet/transformers.rs

SanchithHegde · 2024-11-25T08:34:58Z

crates/router/src/core/payments/transformers.rs

+        let webhook_url = Some(helpers::create_webhook_url(
+            router_base_url,
+            &attempt.merchant_id,
+            connector_name,
+        ));


@Narayanbhat166 @sai-harsha-vardhan Should we consider passing MerchantConnectorAccountId here, instead of the connector name? Basically update the create_webhook_url() function as well?

Yes, it's always recommended to use MerchantConnectorAccountId in webhook url

@sai-harsha-vardhan @SanchithHegde I made a new fn create_webhook_url_using_mca_id ,but only used it in line 226 (crates/router/src/core/payments/transformers.rs:226) . In the other places where create_webhook_url() is currently used the MerchantConnectorAccountId value is Optional, so we cant replace connector name with simply MerchantConnectorAccountId.

we will always have the merchant_connector_id when constructing the router data. So if it is not found you can raise an internal server error.

I do not see any harm in updating the existing webhook function.

updated the existing create_webhook_url fn

crates/router/src/core/payments/helpers.rs

crates/router/src/core/payments/transformers.rs

crates/router/src/core/payments.rs

Narayanbhat166 · 2025-01-06T10:23:28Z

crates/router/src/core/relay/utils.rs

@@ -32,7 +32,7 @@ pub async fn construct_relay_refund_router_data<'a, F>(
    let webhook_url = Some(payments::helpers::create_webhook_url(
        &state.base_url.clone(),
        merchant_id,
-        connector_name,
+        &connector_account.get_id().get_string_repr().to_string(),


why do we need to do to_string if we are taking only the reference

Here create_webhook_url() is accepting &String , and get_string_repr() returns &str that is why used

to_string()

We can update the create_webhook_url() function to accept &str, if not done already.

SanchithHegde · 2025-01-07T11:47:16Z

crates/router/src/core/payments/helpers.rs

@@ -1243,15 +1243,16 @@ pub fn create_authorize_url(
 pub fn create_webhook_url(
    router_base_url: &String,
    merchant_id: &id_type::MerchantId,
-    connector_name: impl std::fmt::Display,
+    merchant_connector_id_or_connector_name: &String,


Suggested change

merchant_connector_id_or_connector_name: &String,

merchant_connector_id_or_connector_name: &str,

Then we can avoid the to_string() calls.

…d-memory-cache * 'main' of github.com:juspay/hyperswitch: feat(connector): [Novalnet] Add zero auth mandate (#6631) feat(router): add support for relay refund incoming webhooks (#6974) chore(version): 2025.01.10.0

cookieg13 requested review from a team as code owners November 21, 2024 11:30

cookieg13 self-assigned this Nov 21, 2024

cookieg13 changed the title ~~Add novalnet zero auth mandate~~ feat(connector): [Novalnet] Add zero auth mandate Nov 21, 2024

cookieg13 force-pushed the addNovalnetSetupMandate branch from df85bb8 to 4fdf8c1 Compare November 22, 2024 06:10

srujanchikke previously approved these changes Nov 25, 2024

View reviewed changes

SanchithHegde reviewed Nov 25, 2024

View reviewed changes

cookieg13 dismissed srujanchikke’s stale review via 0b20c37 November 26, 2024 07:28

cookieg13 force-pushed the addNovalnetSetupMandate branch from 4fdf8c1 to 0b20c37 Compare November 26, 2024 07:28

cookieg13 requested a review from ShankarSinghC November 26, 2024 07:29

cookieg13 force-pushed the addNovalnetSetupMandate branch from 0b20c37 to 73667aa Compare November 26, 2024 07:30

cookieg13 requested review from SanchithHegde and srujanchikke November 26, 2024 11:45

SanchithHegde previously approved these changes Nov 27, 2024

View reviewed changes

crates/router/src/core/payments/helpers.rs Outdated Show resolved Hide resolved

cookieg13 dismissed SanchithHegde’s stale review via 64d9202 November 27, 2024 11:35

cookieg13 force-pushed the addNovalnetSetupMandate branch from 0fd4b9a to 64d9202 Compare November 27, 2024 11:35

cookieg13 removed request for ShankarSinghC and srujanchikke November 27, 2024 11:37

SanchithHegde previously approved these changes Nov 27, 2024

View reviewed changes

srujanchikke previously approved these changes Nov 27, 2024

View reviewed changes

cookieg13 dismissed stale reviews from srujanchikke and SanchithHegde via 4c94106 November 28, 2024 08:18

cookieg13 force-pushed the addNovalnetSetupMandate branch 2 times, most recently from 4c94106 to 004a8b6 Compare November 28, 2024 08:22

Narayanbhat166 reviewed Nov 28, 2024

View reviewed changes

crates/router/src/core/payments/helpers.rs Outdated Show resolved Hide resolved

Narayanbhat166 reviewed Nov 28, 2024

View reviewed changes

crates/router/src/core/payments/transformers.rs Outdated Show resolved Hide resolved

Narayanbhat166 requested changes Nov 28, 2024

View reviewed changes

cookieg13 force-pushed the addNovalnetSetupMandate branch from 004a8b6 to 9f96ab9 Compare December 2, 2024 09:01

cookieg13 dismissed stale reviews from likhinbopanna, srujanchikke, and SanchithHegde via c595f10 January 3, 2025 12:34

cookieg13 force-pushed the addNovalnetSetupMandate branch from a3cf7e0 to c595f10 Compare January 3, 2025 12:34

cookieg13 requested a review from Narayanbhat166 January 3, 2025 12:42

Narayanbhat166 reviewed Jan 3, 2025

View reviewed changes

crates/router/src/core/payments/transformers.rs Outdated Show resolved Hide resolved

Narayanbhat166 reviewed Jan 3, 2025

View reviewed changes

crates/router/src/core/payments/transformers.rs Outdated Show resolved Hide resolved

cookieg13 force-pushed the addNovalnetSetupMandate branch from e742315 to 62920e9 Compare January 6, 2025 08:10

cookieg13 requested a review from Narayanbhat166 January 6, 2025 08:11

Narayanbhat166 reviewed Jan 6, 2025

View reviewed changes

crates/router/src/core/payments.rs Outdated Show resolved Hide resolved

Narayanbhat166 reviewed Jan 6, 2025

View reviewed changes

cookieg13 force-pushed the addNovalnetSetupMandate branch from 62920e9 to a13dbf6 Compare January 6, 2025 12:06

Narayanbhat166 previously approved these changes Jan 7, 2025

View reviewed changes

SanchithHegde reviewed Jan 7, 2025

View reviewed changes

cookieg13 requested review from SanchithHegde and srujanchikke January 8, 2025 07:23

add create_webhook_url fn changes

48a0de4

cookieg13 dismissed Narayanbhat166’s stale review via 48a0de4 January 8, 2025 08:39

cookieg13 force-pushed the addNovalnetSetupMandate branch from a13dbf6 to 48a0de4 Compare January 8, 2025 08:39

SanchithHegde approved these changes Jan 8, 2025

View reviewed changes

Narayanbhat166 approved these changes Jan 8, 2025

View reviewed changes

deepanshu-iiitu approved these changes Jan 8, 2025

View reviewed changes

likhinbopanna approved these changes Jan 8, 2025

View reviewed changes

likhinbopanna added this pull request to the merge queue Jan 10, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 10, 2025

likhinbopanna added this pull request to the merge queue Jan 10, 2025

Merged via the queue into main with commit 7b306a9 Jan 10, 2025
17 of 19 checks passed

likhinbopanna deleted the addNovalnetSetupMandate branch January 10, 2025 09:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(connector): [Novalnet] Add zero auth mandate #6631

feat(connector): [Novalnet] Add zero auth mandate #6631

cookieg13 commented Nov 21, 2024 •

edited

Loading

semanticdiff-com bot commented Nov 21, 2024 •

edited

Loading

SanchithHegde Nov 25, 2024

sai-harsha-vardhan Nov 26, 2024

cookieg13 Nov 26, 2024 •

edited

Loading

Narayanbhat166 Nov 27, 2024

cookieg13 Nov 28, 2024

Narayanbhat166 Jan 6, 2025

cookieg13 Jan 6, 2025

SanchithHegde Jan 7, 2025

SanchithHegde Jan 7, 2025

	merchant_connector_id_or_connector_name: &String,
	merchant_connector_id_or_connector_name: &str,

feat(connector): [Novalnet] Add zero auth mandate #6631

feat(connector): [Novalnet] Add zero auth mandate #6631

Conversation

cookieg13 commented Nov 21, 2024 • edited Loading

Type of Change

Description

Additional Changes

Motivation and Context

How did you test it?

Checklist

semanticdiff-com bot commented Nov 21, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cookieg13 Nov 26, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cookieg13 commented Nov 21, 2024 •

edited

Loading

semanticdiff-com bot commented Nov 21, 2024 •

edited

Loading

cookieg13 Nov 26, 2024 •

edited

Loading