-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: address Rust 1.84.0 clippy lints #7021
Open
Chethan-rao
wants to merge
1
commit into
main
Choose a base branch
from
rust_clippy_1.84.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chethan-rao
force-pushed
the
rust_clippy_1.84.0
branch
from
January 10, 2025 09:59
61e8cec
to
ce9792c
Compare
Chethan-rao
force-pushed
the
rust_clippy_1.84.0
branch
from
January 10, 2025 10:00
ce9792c
to
c09ee85
Compare
SanchithHegde
approved these changes
Jan 10, 2025
apoorvdixit88
approved these changes
Jan 10, 2025
Narayanbhat166
approved these changes
Jan 10, 2025
AkshayaFoiger
approved these changes
Jan 10, 2025
swangi-kumari
approved these changes
Jan 10, 2025
prajjwalkumar17
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR addresses the clippy lints occurring due to new rust version 1.84.0
Majorly addresses
unnecessary_map_or
clippy lint - https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_orAdditional Changes
Motivation and Context
How did you test it?
CI checks should pass as this PR addresses clippy lints.
just clippy
with new rust version (1.84.0)just clippy_v2
with new rust version (1.84.0)Checklist
cargo +nightly fmt --all
cargo clippy