Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🙈 add full copy of half to dev dep with rand_distr feature #68

Merged
merged 4 commits into from
Aug 24, 2024

Conversation

jvdd
Copy link
Owner

@jvdd jvdd commented Aug 23, 2024

  • fix bug with half its dev-dependency specification
  • fix bug in CI (codspeed installation)

Copy link

codspeed-hq bot commented Aug 24, 2024

CodSpeed Performance Report

Merging #68 will degrade performances by 17.44%

Comparing fix_dep_error (0565016) with main (eff8899)

Summary

⚡ 8 improvements
❌ 7 regressions
✅ 153 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix_dep_error Change
scalar_f16_argminmax_in 747.8 µs 776.2 µs -3.66%
scalar_f32_argmax_in 442.9 µs 457.2 µs -3.12%
scalar_f32_argmin_in 442.9 µs 457.2 µs -3.12%
scalar_f32_argminmax_in 471.4 µs 571 µs -17.44%
scalar_f64_argmax_in 629.6 µs 643.9 µs -2.22%
scalar_f64_argmin_in 629.6 µs 643.9 µs -2.22%
scalar_f64_argminmax_in 658.1 µs 757.7 µs -13.15%
scalar_i16_argminmax 363.8 µs 349.6 µs +4.07%
scalar_i32_argminmax 457.1 µs 442.9 µs +3.2%
scalar_i64_argminmax 643.8 µs 629.5 µs +2.27%
scalar_i8_argminmax 374 µs 359.8 µs +3.96%
scalar_u16_argminmax 363.8 µs 349.5 µs +4.08%
scalar_u32_argminmax 457.1 µs 442.9 µs +3.21%
scalar_u64_argminmax 643.8 µs 629.6 µs +2.25%
scalar_u8_argminmax 374 µs 359.8 µs +3.95%

@jvdd jvdd merged commit ec2607d into main Aug 24, 2024
20 of 21 checks passed
@jvdd jvdd deleted the fix_dep_error branch August 24, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant