Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue82 #84

Merged
merged 2 commits into from
Nov 3, 2018
Merged

Issue82 #84

merged 2 commits into from
Nov 3, 2018

Conversation

jverzani
Copy link
Owner

@jverzani jverzani commented Nov 3, 2018

  • comments on issue Non existant partial inclusions fail silently #83 leaving stub in case this change is desired
  • Address issue (Not indefinitely) Recursive partials templates fail to parse #82 The partials were receiving the context including the parent, and this would cause infinite recursions in the example. Now the context for partials is just the value and the immediate view. This means that a partial's values only get resolved within the most immediate context. This is a change, but I don't know what the spec says about this, and this change seems to make sense, so will be considered a bug fix and not breaking.

@jverzani jverzani merged commit ccdaa6a into master Nov 3, 2018
@jverzani jverzani deleted the issue82 branch November 3, 2018 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant