Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Viewers are able to subvert the Simultaneous login limit #419

Merged
merged 4 commits into from
Jan 16, 2024

Conversation

borkopetrovicc
Copy link
Contributor

Description

https://www.notion.so/jwplayer/Viewers-are-able-to-subvert-the-Simultaneous-login-limit-baf6baf8ba9946978ea573d871644279

This PR solves # .

Steps completed:

According to our definition of done, I have completed the following steps:

  • Acceptance criteria met
  • Unit tests added
  • Docs updated (including config and env variables)
  • Translations added
  • UX tested
  • Browsers / platforms tested
  • Rebased & ready to merge without conflicts
  • Reviewed own code

Copy link

github-actions bot commented Dec 20, 2023

Visit the preview URL for this PR (updated for commit c5c52f9):

https://ottwebapp--pr419-simultaneous-logins-n0wa9mw2.web.app

(expires Thu, 15 Feb 2024 09:25:01 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c198f8a3a199ba8747819f7f1e45cf602b777529

@borkopetrovicc borkopetrovicc requested review from AntonLantukh and kiremitrov123 and removed request for naumovski-filip December 21, 2023 10:10
@borkopetrovicc borkopetrovicc requested review from AntonLantukh and removed request for darkoatanasovski and kiremitrov123 January 12, 2024 11:48
@borkopetrovicc borkopetrovicc requested review from AntonLantukh and removed request for AntonLantukh January 16, 2024 11:36
@borkopetrovicc borkopetrovicc merged commit ff3b2bc into develop Jan 16, 2024
9 checks passed
@borkopetrovicc borkopetrovicc deleted the simultaneous-logins-limit-bug branch January 16, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants