Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add user_id and profile_id for CDN analytics #420

Merged
merged 7 commits into from
Jan 18, 2024

Conversation

olga-jwp
Copy link
Collaborator

@olga-jwp olga-jwp commented Dec 20, 2023

Description

OWA-52

Steps completed:

According to our definition of done, I have completed the following steps:

  • Acceptance criteria met
  • Unit tests added
  • Docs updated (including config and env variables)
  • Translations added
  • UX tested
  • Browsers / platforms tested
  • Rebased & ready to merge without conflicts
  • Reviewed own code

@olga-jwp olga-jwp added the forming This idea is a brainstorm, green field, or work in progress label Dec 20, 2023
@olga-jwp olga-jwp requested a review from dbudzins December 20, 2023 18:24
Copy link

github-actions bot commented Dec 20, 2023

Visit the preview URL for this PR (updated for commit 63bc329):

https://ottwebapp--pr420-owa-52-add-user-prof-ugxv8d2p.web.app

(expires Sat, 17 Feb 2024 10:11:26 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c198f8a3a199ba8747819f7f1e45cf602b777529

@olga-jwp olga-jwp removed the forming This idea is a brainstorm, green field, or work in progress label Jan 12, 2024
Copy link
Contributor

@dbudzins dbudzins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small comments, but looks like it's almost there!

@olga-jwp olga-jwp requested a review from dbudzins January 17, 2024 14:16
@olga-jwp olga-jwp merged commit da6c07c into develop Jan 18, 2024
9 checks passed
@olga-jwp olga-jwp deleted the OWA-52-add-user-profile-id-for-cdn-analytics branch January 18, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants