Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat / Translated menu titles in sidebar #637

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

royschut
Copy link
Collaborator

@royschut royschut commented Nov 6, 2024

Description

This PR builds onto #612 and adds the translated menu title to the sidebar as well.

Steps completed:

According to our definition of done, I have completed the following steps:

  • Acceptance criteria met
  • Unit tests added
  • Docs updated (including config and env variables)
  • Translations added
  • UX tested
  • Browsers / platforms tested
  • Rebased & ready to merge without conflicts
  • Reviewed own code

Copy link

github-actions bot commented Nov 6, 2024

Visit the preview URL for this PR (updated for commit afb65b4):

https://ottwebapp--pr637-feat-custom-label-si-lcm27g5p.web.app

(expires Sat, 07 Dec 2024 11:14:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c198f8a3a199ba8747819f7f1e45cf602b777529

@royschut royschut marked this pull request as ready for review November 7, 2024 11:13
Copy link
Collaborator

@langemike langemike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted!

@royschut royschut merged commit b73ae54 into develop Nov 7, 2024
10 checks passed
@royschut royschut deleted the feat/custom-label-sidebar branch November 7, 2024 14:59
This was referenced Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants