Refactor / sync ott changes #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristiaanScheermeijer
requested review from
langemike,
dbudzins,
AntonLantukh,
royschut and
olga-jwp
|
Visit the preview URL for this PR (updated for commit 1d642f8): https://ottwebapp--pr664-refactor-sync-ott-ch-oi39cy00.web.app (expires Sat, 08 Feb 2025 10:25:08 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c198f8a3a199ba8747819f7f1e45cf602b777529 |
langemike
approved these changes
Jan 7, 2025
royschut
approved these changes
Jan 7, 2025
|
@langemike @royschut I added the missing DRM property as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have made changes in the fork that allows us using the
useWatchHistoryhook for capacitor and react native platforms as well. For this, the JW Player instance parameter is removed in the hooks and more player events are exposed as callback prop.This PR also contains a small change that decreases the shelf title font size for mobile devices.
Both changes have been in the fork for a while and are well tested.