Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize common directories once #5581

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Initialize common directories once #5581

wants to merge 2 commits into from

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Feb 13, 2025

Description

Consolidate directory creation to the beginning of the controller and worker startup.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123
Don't initialize run directory in supervisor
f865712 
This should have been done by the caller already.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123
Initialize common directories once
8845643 
Consolidate directory creation to the beginning of the controller and
worker startup.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 added the chore label Feb 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that need to be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
chore merge-conflict
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@twz123