Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Temporarily revert version of goccy/go-json to support data race #1157

Merged
merged 5 commits into from
Jan 24, 2025

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Jan 24, 2025

@k1LoW k1LoW added the dependencies Pull requests that update a dependency file label Jan 24, 2025
@k1LoW k1LoW self-assigned this Jan 24, 2025

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@k1LoW k1LoW force-pushed the fix-goccy-json-version branch from 6f46f31 to 5f2c2e3 Compare January 24, 2025 02:52

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

BenchmarkManyRunbooks-4

main (-) #1157 (f2fabec) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 3,719,681,647 ns/op 3,571,687,118 ns/op -147,994,529 ns/op
Bytes allocated per iteration 1,383,789,896 B/op 1,383,490,648 B/op -299,248 B/op
Allocs per iteration 19,142,870 allocs/op 19,142,717 allocs/op -153 allocs/op
Metadata
main (-) #1157 (f2fabec)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkOpenAPI3-4

main (-) #1157 (f2fabec) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 4,963,359,965 ns/op 5,104,690,930 ns/op 141,330,965 ns/op
Bytes allocated per iteration 2,319,818,008 B/op 2,319,705,496 B/op -112,512 B/op
Allocs per iteration 31,820,772 allocs/op 31,817,988 allocs/op -2,784 allocs/op
Metadata
main (-) #1157 (f2fabec)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkSingleRunbook-4

main (-) #1157 (f2fabec) +/-
Number of iterations 25 24 -1
Nanoseconds per iteration 47,249,642 ns/op 46,321,240 ns/op -928,402 ns/op
Bytes allocated per iteration 23,166,556 B/op 23,162,861 B/op -3,695 B/op
Allocs per iteration 184,805 allocs/op 184,823 allocs/op 18 allocs/op
Metadata
main (-) #1157 (f2fabec)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

Reported by octocov

Copy link
Contributor

Code Metrics Report

main (bf23163) #1157 (f2fabec) +/-
Coverage 63.3% 63.3% -0.1%
Code to Test Ratio 1:0.7 1:0.7 +0.0
Test Execution Time 6m30s 5m13s -1m17s
Details
  |                     | main (bf23163) | #1157 (f2fabec) |  +/-   |
  |---------------------|----------------|-----------------|--------|
- | Coverage            |          63.3% |           63.3% |  -0.1% |
  |   Files             |             78 |              78 |      0 |
  |   Lines             |           9011 |            9011 |      0 |
- |   Covered           |           5708 |            5707 |     -1 |
+ | Code to Test Ratio  |          1:0.7 |           1:0.7 |   +0.0 |
  |   Code              |          16564 |           16564 |      0 |
+ |   Test              |          12658 |           12662 |     +4 |
+ | Test Execution Time |          6m30s |           5m13s | -1m17s |

Reported by octocov

@k1LoW k1LoW merged commit 2bf1174 into main Jan 24, 2025
9 checks passed
@k1LoW k1LoW deleted the fix-goccy-json-version branch January 24, 2025 03:50
@github-actions github-actions bot mentioned this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant