Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for bind to slice/map values #699

Merged
merged 7 commits into from
Nov 28, 2023
Merged

Support for bind to slice/map values #699

merged 7 commits into from
Nov 28, 2023

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Nov 28, 2023 •
edited
Loading

ref: #569

bind:
  "foo[i]": current.res
bind:
   "foo[]": current.res

@k1LoW
Support for bind to map values
d3ffcd8 
ref: #569

```yaml
bind:
  vars:
    "foo[i]": current.res
```
@k1LoW k1LoW added enhancement New feature or request breaking-change labels Nov 28, 2023
@k1LoW k1LoW self-assigned this Nov 28, 2023
@k1LoW k1LoW marked this pull request as draft November 28, 2023 01:35
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
k1LoW added 3 commits November 28, 2023 14:45
@k1LoW
Support to bind to slice values
a2ba51c 
ref: #569

```yaml
bind:
  vars:
    "foo[]": current.res
```
@k1LoW
bonsai
15c29bc
@k1LoW
Merge pull request #700 from k1LoW/bind-slice
28cd0a7 
Support to bind to slice values
@k1LoW k1LoW changed the title Support for bind to map values Support for bind to slice/map values Nov 28, 2023
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@k1LoW k1LoW marked this pull request as ready for review November 28, 2023 06:04
@k1LoW k1LoW added the minor label Nov 28, 2023
@k1LoW k1LoW mentioned this pull request Nov 28, 2023
Closed
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@k1LoW k1LoW requested a review from k2tzumi November 28, 2023 11:22
k2tzumi added a commit to k2tzumi/runn-tutorial that referenced this pull request Nov 28, 2023
@k2tzumi
refs k1LoW/runn#699
c01130e
@github-actions GitHub Actions
Copy link
Contributor

Code Metrics Report

main (fabb24d) #699 (0e02682) +/-
Coverage 73.4% 73.6% +0.1%
Code to Test Ratio 1:0.7 1:0.7 +0.0
Test Execution Time 3m41s 2m47s -54s
Details 
  |                     | main (fabb24d) | #699 (0e02682) |  +/-  |
  |---------------------|----------------|----------------|-------|
+ | Coverage            |          73.4% |          73.6% | +0.1% |
  |   Files             |             46 |             46 |     0 |
  |   Lines             |           5717 |           5825 |  +108 |
+ |   Covered           |           4198 |           4285 |   +87 |
+ | Code to Test Ratio  |          1:0.7 |          1:0.7 |  +0.0 |
  |   Code              |          12021 |          12228 |  +207 |
+ |   Test              |           8386 |           8800 |  +414 |
+ | Test Execution Time |          3m41s |          2m47s |  -54s |

Code coverage of files in pull request scope (84.2% → 81.1%)

Files Coverage +/-
bind.go 81.1% -3.1%

Reported by octocov

k2tzumi
k2tzumi approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@k2tzumi k2tzumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we can leave the result in the loop process!
Very good!

@k2tzumi k2tzumi merged commit 9821018 into main Nov 28, 2023
7 checks passed
@k2tzumi k2tzumi deleted the bind-slice-map branch November 28, 2023 13:18
@github-actions github-actions bot mentioned this pull request Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k2tzumi k2tzumi k2tzumi approved these changes

Assignees

@k1LoW k1LoW

Labels
breaking-change enhancement New feature or request minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k1LoW @k2tzumi