Add CMake option to disable/enable TTS support #500
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkjaran
force-pushed
the
conditional-compilation-tts
branch
from
df9db5d to
f37b2d1
Compare
rkjaran
force-pushed
the
conditional-compilation-tts
branch
from
f37b2d1 to
b0b444a
Compare
rkjaran
commented
Dec 21, 2023
sherpa-onnx/c-api/c-api.h
Outdated
| @@ -600,6 +600,8 @@ SHERPA_ONNX_API void SherpaOnnxDestroySpeechSegment( | |||
| SHERPA_ONNX_API void SherpaOnnxVoiceActivityDetectorReset( | |||
| SherpaOnnxVoiceActivityDetector *p); | |||
|
|
|||
| #if defined(SHERPA_ONNX_ENABLE_TTS) | |||
There was a problem hiding this comment.
I should probably invert this, so as to not break the examples.
csukuangfj
reviewed
Dec 22, 2023
| ) | ||
|
|
||
| if(SHERPA_ONNX_ENABLE_TTS) | ||
| list(APPEND sources |
There was a problem hiding this comment.
How about to build a separate library for tts, e.g., libsherpa-onnx-core-tts.so?
If you only want to use the ASR part, then you don't need to link with libsherpa-onnx-core-tts.so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds a CMake option
SHERPA_ONNX_ENABLE_TTSwhich isONby default tocontrol whether to compile TTS support.
Closes #498