fix: Resolve deprecation warning by using explicit UTC timezone instead of datetime.utcnow
#15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brouberol
force-pushed
the
patch-1
branch
2 times, most recently
from
7d74fd8 to
71e4bca
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 154 158 +4
=========================================
+ Hits 154 158 +4
☔ View full report in Codecov by Sentry. |
|
Hey, @brouberol thank you for your PR! Note: I've merged main to your branch to run it on 3.12. |
brouberol
force-pushed
the
patch-1
branch
3 times, most recently
from
4d535f2 to
10625e3
Compare
…ow` in py3.12 Starting from python 3.12.0, we started seeing some deprecation warning related to use of `datetime.datetime.utcnow`: ``` /Users/.../lib/python3.12/site-packages/fastapi_jwt/jwt.py:135: DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC). now = datetime.utcnow() ``` This PR should provide the same level of functionality without firing a deprecation warning, by implementing the suggested change.
|
@k4black thanks for the feedback! We should be good. I've rebased my branch on your |
k4black
changed the title
datetime.utcnowdatetime.utcnow
|
lgtm, thank you! <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from python 3.12.0, we started seeing some deprecation warning related to use of
datetime.datetime.utcnow:This PR should provide the same level of functionality without firing a deprecation warning, by implementing the suggested change.