Fix gnome-online-accounts by enabling gnome-keyring and unsetting SSH_AUTH_SOCK #1037
+26
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Intentionally preferring existing variable since init nix-community/home-manager#4178 |
kachick
commented
Jan 10, 2025
nixos/desktop/default.nix
Outdated
| @@ -102,7 +102,7 @@ | |||
| # https://github.com/NixOS/nixpkgs/issues/101616 | |||
| # | |||
| # Using mkforce for https://discourse.nixos.org/t/gpg-smartcard-for-ssh/33689/3 | |||
| services.gnome.gnome-keyring.enable = lib.mkForce false; | |||
| # services.gnome.gnome-keyring.enable = lib.mkForce false; | |||
There was a problem hiding this comment.
Can I simply resolve this after NixOS/nixpkgs#310978?
There was a problem hiding this comment.
I should remember why I should avoid gnome-keyring in SSH_AUTH_SOCK
There was a problem hiding this comment.
How to enabling the env is...
- https://github.com/NixOS/nixpkgs/blob/8cde48031da322bb1039740d72816fde20aea25f/nixos/modules/services/desktops/gnome/gnome-keyring.nix#L38C33-L38C51
- https://github.com/NixOS/nixpkgs/blob/8cde48031da322bb1039740d72816fde20aea25f/nixos/modules/security/pam.nix#L726
- https://github.com/NixOS/nixpkgs/blob/8cde48031da322bb1039740d72816fde20aea25f/nixos/modules/security/pam.nix#L966-L970
kachick
commented
Jan 10, 2025
| configureFlags = final.lib.lists.remove "--enable-ssh-agent" previousAttrs.configureFlags; | ||
| } | ||
| ); | ||
| }) |
There was a problem hiding this comment.
After this change
> echo $SSH_AUTH_SOCK
/run/user/1001/ssh-agentHowever it takes minutes for build...
There was a problem hiding this comment.
Rebuilding my system increased 6 minutes 😢
There was a problem hiding this comment.
Another idea is overriding the SSH_AUTH_SOCK with following steps.
There was a problem hiding this comment.
However it might make confusion for many existing code.
kachick
changed the title
kachick
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes GH-1034 and Closes GH-1036
Fixes GH-1015 with updating GH-978 and GH-814