feat: fix lock-and-fetch for MySQL #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The support was nearly finished in kagkarlsson#371 but later commented out due to "some issue [..] and limited time". I tried to find out what those issues were and discovered that the syntax of the select was wrong. In MySQL the `LIMIT` comes before the `FOR UPDATE SKIP LOCKED`. Using that fix `Mysql8CompatibilityTest` passes, I have done no further testing yet.
|
Wow, nice job! I just got to a point where time was running out and I just needed to merge the PR. So I took MySQL and MariaDB out again 😅. I really appreciate the effort of digging out the details and fixing it 🙏 Hopefully I can have a quick review of this next week, but looks good on first glance. Probably should refactor into some better form of query-builder, but that is a bit out-of-scope here.. |
kagkarlsson
approved these changes
Nov 20, 2024
db-scheduler/src/main/java/com/github/kagkarlsson/scheduler/jdbc/Queries.java
Show resolved
Hide resolved
|
Frustratingly the option to run the build disappeared after approving. I will have to merge blind and hope the tests run, else I might need to revert.. |
|
🎉 This issue has been resolved in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief, plain english overview of your changes here
The support was nearly finished in #371 but later commented out due to "some issue [..] and limited time".
I tried to find out what those issues were and discovered that the syntax of the select was wrong. In MySQL the
LIMITcomes before theFOR UPDATE SKIP LOCKED.Using that fix
Mysql8CompatibilityTestpasses, I have done no further testing yet.Fixes
#264
Reminders
mvn spotless:applycc @kagkarlsson