fix: Adding equals and hashcode for CronSchedule #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kagkarlsson Can you please merge this? |
kagkarlsson
reviewed
Nov 16, 2024
db-scheduler/src/test/java/com/github/kagkarlsson/scheduler/task/CronTest.java
Outdated
Show resolved
Hide resolved
|
Thank you for contributing. Minor comment |
kagkarlsson
reviewed
Nov 20, 2024
db-scheduler/src/test/java/com/github/kagkarlsson/scheduler/task/CronTest.java
Outdated
Show resolved
Hide resolved
kagkarlsson
reviewed
Nov 20, 2024
Comment on lines
+150
to
+152
| @Test | ||
| public void equals_and_hash_code() { | ||
| EqualsVerifier.forClass(CronSchedule.class).verify(); |
0x01F4
changed the title
kagkarlsson
approved these changes
Nov 29, 2024
I want reschedule on config change but when we reschedule next execution time change.So I want to check if schedule is same then we don't reschedule. |
|
@kagkarlsson can you merge this? |
|
🎉 This issue has been resolved in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief, plain english overview of your changes here
Adding Equals and HasCode for CronSchedule
Fixes
Reminders
mvn spotless:applycc @kagkarlsson