Http Redirect for downloads crl and crt #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaikramer
reviewed
Nov 18, 2023
| private void downloadCrl(URL url) throws IOException, CryptoException { | ||
| URLConnection urlConn = url.openConnection(); | ||
| HttpURLConnection urlConn = (HttpURLConnection) url.openConnection(); |
There was a problem hiding this comment.
Did you have the possibility to test this with a proxy? I vaguely remember that there was an issue when using HttpURLConnection (ignoring the proxy settings).
There was a problem hiding this comment.
Works correctly using this type of proxy
There was a problem hiding this comment.
Ok, I'll do a few tests next week.
There was a problem hiding this comment.
Worked fine in my tests. Unfortunately I don't have access to the proxy anymore where I have noticed the issues a few years ago.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.